Something that people occasionally miss is that several hotkey actions
double as menu items throughout the UI. Menu items have this particular
quality to them that requires them to be as succinct as possible to make
their meaning apparent without requiring excessive reading and parsing
from users/players. Furthermore, in a UI like ours with large elements
everywhere, we want to avoid excessively wordy elements that can become
ten times as long when translated into foreign languages.
Commit c42bf114249dcef5241327ca92214cf155ff89e8 replaced the Preferences
label with a unnecessarily longer version despite it being pretty
standard among most applications for it to be a single word (either
Preferences or Options or Settings). This commit reverts that.
Clear Chat and Errors (also from the aforementioned commit) is relabeled
Clear Chat rather than Clear Messages so it's clearer that it applies to
chat messages in particular and not anything else. On that note, the
fact that game diagnostics share real estate and infrastructure with
chat is really unfortunate but there's not much that can be done about
it at the moment. At least it is visually obvious that this is the case.
It's also rarely relevant (and most people won't think of entering
"error" into the hotkey filter before reporting the error somewhere).
View Chat Log is relabeled Chat Log since no other option deals with the
Chat *Log* in particular.
Scenario Objectives is relabeled Objectives because there really isn't
anything else that has objectives we can look at in the whole game.
Enter User Command is relabeled Enter Command so as to not sound
superfluous.
Additionally, the Quit to Main Menu action is relabeled just Quit to
Menu, which is closer to what the option actually does in MP games (quit
to lobby) without being inaccurate in either SP or MP (closes#2744).
Categories vs. Filter both deal with filtering -- the only difference is
that categories has a broader scope than the name-based filtering, with
the latter being applied to results for the selected categories. We
don't need two rows for both.
This is specifically meant to address the sidebar gaining a short
vertical scrollbar at higher resolutions because of button sizes
increasing slightly.
The hardcoded size of the window was too small for the large fonts on HDPI
displays, this changes to using the automatic width and calculated-based-on-dpi
height. On HDPI displays that does leave blank space on the General tab, but it's
better than not scaling.
Buttons that were placed at the bottom of pages move up so that they aren't
too far from the other controls. The sub-tab-selector buttons on the
multiplayer tab move above the sub-tabs themselves.
With HDPI text, the checkboxes are placed a little too high to align with
the font, but that's a cosmetic detail; this commit fixes the usability issue.
Colours obtained from help markup until now have been generated using
from_argb_bytes(), even though the caller ensures they are 7 characters
long and thus in #RRGGBB hex notation. When porting the help text render
code to pango_text, this resulted in text with colour set by markup
being rendered invisible with an alpha value of 0.
Unless we decide at a later point to support alpha values in help
markup, we want alpha to always be 255.
