The units on the outsides of a backstab don't have to be allied
to each other, they just have to be enemies of the victim. That's
hardcoded into the AI via attack.cpp's backstab_check() function,
hence a unit test to check that WEAPON_SPECIAL_BACKSTAB activates
in that situation.
Add a new map with 4 sides all on separate castles. This is a
variation of the generic 2p unit test map, extended in the south
with a horizontal reflection of existing map.
Add a MAP_FILE argument to COMMON_KEEP_A_B_C_D_UNIT_TEST,
because it's the same setup except for the map file.
Treat an argument of "--help" as a request to print help, instead of a filename
to add to the source lists.
Treat the arguments "src/foo.cpp" "src/foo.hpp" as two filenames, instead of
adding src/foo.cpp to target src/foo.hpp. The old command line
./add_source_file a b c
becomes
./add_source_file a --target b --target c
When saying that pbxproj is required, suggest optionally using a venv instead
of installing systemwide.
Original Eastern Invasion rework's Shadow Mage/Lord stats were based on undead's 50% arcane vulnerability. With the arcane rebalance, the Mage/Lord's arcane weapon is almost never worth using. This commit adjusts the Lord/Mage's arcane/impact weapons.
This avoids issues if the events being executed add new handlers, since adding a new handler needs to sort the list according to the event priority.
Fixes#8157
Prefixing all system and group names with the underscore is
recommended by the systemd developers.
This reverts commit d6d2a4f9967be5cce600d581eabf252138ef79ac.
In S11, make the first deserter always male so the translations don't need to
worry about gender variants. However, add gender variants to the strings that
talk to that deserter, as they're new in 1.17.
Address a few weird or problematic entries in the glossary. This also makes it use the term "glossary" instead of "dictionary", as that's what it really is.
Fixes the display of topic headings, including unit names, in right to left
languages (Arabic and Hebrew).
The GUI1 menu code is only kept to support one UI feature, the help browser.
However, the code supported multiple columns and multiple things in each
column; to do the latter it handled each column as a string with embedded
separators. To support the help GUI, all that's needed is for each row to have
an indent, an icon, and a text field. Traces of the multiple-column support are
still in the code, but the drawing code is simplified.
The logic for working out whether mouse clicks are on the icon or the text has
moved from the subclass to the main menu class, as it's a subset of the logic
for drawing the UI.
In LTR languages, this looks almost identical.
In RTL languages, the book icons now appear in the right place, and the text
placement is reasonable.
Remove some special cases from the drawing code, because menu::draw_row
was previously also used for drawing the headings.
As scale_images was never called, adjust_image_bounds was a no-op.
This is separate from the main dead code removal commit because it touches
active code paths.
The GUI1 menu code is only kept to support one UI feature, the help browser.
More specifically, the left-hand pane that looks like a treeview.
Remove the code for sorting the list in the UI. The help articles are ordered
by category, and there isn't a UI control for the user to sort them into a
different order.
Remove erase_item(), which wasn't called from anywhere.
Remove clear_item(), recalculate_pos() and assert_pos(). These three were
only called by the sorting code and erase_item().
The replaced first line added facts into canon that didn't need to be there.
Also, that text felt too similar to some real-world racism, which is why I'm
pushing this change during the string freeze.
In discussion during review, the last two lines felt more like the start of
another story than part of WoF itself.
man 5 sysuses.d recommends:
It is strongly recommended to pick user and group names that are unlikely to clash with normal users created by the administrator.
A good scheme to guarantee this is by prefixing all system and group names with the underscore, and avoiding too generic names.
Looks better without underscore. wesnoth is unique enough to not clash, most daemons on Arch don't have an underscore either.
The group is created implicitely when the user is created.
If case insensitive handling is wanted here then it needs to show all matches not just an arbitrary first one.
Since this forwards to searchlog which properly matches case insensitively anyway that does not seem particularly useful though.
