Hopefully, we'll be able to implement better support for layouts that don't relay on pixel canvas sizes, but for now, this solves two important issues:
Using 1280x720 as the default window size means 3x auto pixel scaling for 4k fullscreen, which looks utterly horrendous and unusable. 2x is the practical limit of usability without going so far in the opposite direction as to actually reduce the available space.
Bumping the min window size also resolves#9898 and saves us from having to deal with layouts on unusably small windows.
As a side note, we should not be thinking in terms of pixel size anymore. I'm hoping SDL3 can give us better control over our HDPI support (which is much improved from before), but the fact remains that our current pixel scaling implementation is, essentially, a method to scale up the canvas if your resolution is grater than 1080p. It does nothing for size calculations, and it does nothing if you actually set a window size smaller than 1080p even on a 4k monitor.
So, for now, imperfect solution while we wait for SDL3, but solves the immediate issues with scaling and small window sizes.
It is clearer than including them into the unit types.
This commit is restoring the weapon special note which was mistakenly
left unused and then was removed in PR #9864 .
Unit recall cost will be similar to 1.18, red if greater than team's recall cost, green if less and white if equal.
In addition, will be greyed out if the unit can't be recalled.
* redesign Dune Paragon around the current Blademaster, to avoid RIPLIB
* change Dune Paragon's longsword to scimitar for consistency with Blademaster
* buffed pommel strike and added stun as requested by Dalas
* removed stun from paragon
* increased dune paragon price
* revert Dune Paragon pommel strike back to 11x3
* dune paragon price 81 > 85
No viable conversion from returned value of type 'basic_string<char, char_traits<char>, allocator<char>>' to function return type 'utils::optional<t_string>'
* Remove STARTING_VILLAGES
There are no villages close enough anyway.
* Fix revealing villages
Use the coordinates of the ogre village instead of what probably were
two removed villages.
* Remove capture of non-existent village
There is no village at 32,13. The nearest one is at 36,11, and it is too
far for Mortic too reach in one turn, so they don't even try.
* Simplify human-meets-ogre event
Instead of repeatedly running FIND_NEARBY, use already assigned unit and
second_unit variables.
* Simplify ogre-meets-ogre event
Use already assigned "unit" variable and find another unit adjacent to
it.
* Fix bugs in Grug-meeets-ogre event
There were two bugs. First, calling FIND_NEARBY with $found_unit as an
argument causes a clash with its internal variable and leads to the
wrong (not nearest) unit being selected. Second, the last message used
$unit instead of $found_unit, which made Grug say this line instead of
the wild ogre.
* Use $this_item instead of $unit in foreach
To avoid clashes with $unit automatically assigned in other events.
* Fix clearing variables
Remove clearing variables that are not actually used, clean those which
are used. Remove elixir_drinker variable from the macro as we use the
trait instead.
* Use $x1, $y1 instead of $unit fields
Makes the code a bit shorter.
* Simplify drake sighted event
Replace FIND_NEARBY with simple condition.
* Rename variables
our_id to our_unit_id, their_id to their_unit_id
I'm not sure I want to keep this API, honestly, but this is the more proper behavior. Before I added precise_subrect, it partially fixed the precision issues I had with the new unit bar rendering.
