data/core/editor/items.cfg defines the names for the items. The file is
included by data/core/editor/_main.cfg, which has a #textdomain binding
to wesnoth-editor at the top. The strings end up bound to that
textdomain by the game, but wmlxgettext doesn’t have any way to see this
so it binds them to the default textdomain instead, which is wesnoth,
not wesnoth-editor. The game ends up looking for the strings in
wesnoth-editor instead.
The easiest solution right now is to explicitly bind items.cfg to the
wesnoth textdomain so as to not require moving catalogue entries in the
po files around to wesnoth-editor. It really should've been
wesnoth-editor in the first place but it's too late to fix that now
without giving translators a migraine. It's a pity either way given how
useless the scenario editor is in practice.
[ci skip]
Icon [short_arrow_left_25-pressed.png] exists, but is not used anywhere.
Widgets in [menu_button_default.cfg] and [multimenu_button_default.cfg]
were using [short_arrow_left_25-active.png] for the "pressed" state.
This will less often wrap the text of the descriptions.
For many of the zombies is more possible, but it has been taken care to have the
linebreak for 'required xp' and in the variation list the same on all their pages.
The reason for the 319px height on some of them is:
- It's still taking enough space to have 'required xp' on a new line.
- It does for both the WC and Soulless not interfere with the description text.
- The swimmer can't be smaller than 319px without cutting any non-tranaparent
pixel. To have more structure the goblin/dwarf/dog use the same.
[ci skip]
If in attack end in FORCE_CHANCE_TO_HIT macro, unit or second unit doesn't exist anymore because rare case where unit disapear before attack end event was calledthen we have an error message like "Invalid WML found: [unstore_unit]: variable 'second_unit' doesn't exist" because presence of unit not condition of execution of event.
* josteph/forward-port-some-of-the-174:
don't call invalidate_layout() unless needed
Convert a bunch more C-style casts I missed in 0dc5656 to static_cast
fixup don't show travis notifications from forks (cherry picked from commit 55bc62f442da47f0b754ed9b75238c5a53fd76dd)
don't show travis notifications from forks (cherry picked from commit d6ab780ce94df14a6eb1eeb4df7ce2543fc27069)
fix out of bonunds check
Lua: Invalidate layout in set_dialog_value()
Fix includes
Implement iOS version detection
Game Load: Use child_or_empty().
Themes: Fix the observers icon being hidden under the minimap
Game Load: Restore the ability to select 1.12.6 savegames in the list
Fix CMake build on macOS
NR S8: compatibility commit to make the new companions from scratch if we don't have them stored
Partially revert "Additional village variations (#3342)"
DM: Add last breath dialog for Zorlan
DM: Generalize death message so it works when Delfador is young and old
gui2/unit_recall: Change Recall button back to its correct label
Updated changelog in Xcode
Add WML unit test for unupgradable (#3336)
gui2/unit_recall: Fix i18n issues
DM: add some TODOs
iOS: finger scrolling in controls.
iOS document directories. Might use these on other platforms as well.
.gitignore for CLion
German multiplayer translation: fixes
German translation: reword era descriptions
German translation: fix a string
Statistics Dialog: merge unit name and count labels
add / remove some comments
Tutorial Part2: Give the player a canche to undo his move
UtBS 5: changes to scenario locations (#3104)
Update changelog in macOS package
SotA: transform bats already after the 5th scenario
TRoW: revert workaround for #2912
Changelog entry for the #2912 work around
TRoW: Increase Rithrandil's workaround portrait height to 700
TRoW: IPF-downscale Rithrandil's portrait, as a workaround to #2912
Add missing deprecation messages for deprecated macros
Northern Rebirth S02_01: keep side 8 leader from wandering off too far
changelog: remove AToTB AI entry
wesnothd: prevent another instance of crash from owner not in player_connections
Increased in-game chat size. This makes it render more smoothly
Minor tweaks to classic theme (thanks enclave for doing this)
Update RELEASE_NOTES (cherry picked from commit e2a2a85f16fb5984ad0e44b0ec3f16a5eb1ac823)
Update changelog for custom AI for AToTB S2
TRoW: revert changes, to avoid a potential OOS
Re-apply patches to fix issues #2844 and #2846 in SotA
Clear RELEASE_NOTES
Repair 66ab35f in the upwards direction
Add changelog for 1.14.0
add placeholer links to appdata file
Hide Editor help section
UtBS: readd do_not_list
UtBS: wmlindent pass
Fix MP label for #2855
Fixup 601c67d970c2eac
UtBS: Re-added compatibility code to load old saves using the new elves
Swap count and name columns in statistics (fixes#2893)
Revert string changes in SotA for 1.14 RC 3 - gold
AI recruitment: use unit-specific recall cost
AI recruitment: fix units on recall list interfering with recruiting
Fixup f7ab008 before GCC complains about an unused parameter >_<
Help: disabled parsing error popup
LoW: Fix translation error in conjunct list (fixes#2833) (#2834)
Fix pofix
Changelog entry for recent SotA fixes
Pofix entry for fc6c3ac04b899b4c7f629a1cd8d80101c7cbb20c
Pofix entry for b86a2968fe87a7e4112e900070446d4a83808202
Pofix entry for ab9f29a7a44372a3e3703fd842740a9b425b6f5f
Fix HP label in longer languages
Help: removed sort_sections key with invalid value
less redraw_everything calls when receiving [change_controller]
fix gui2 dialog disappearing after [change_controller]
Use a fallback for when the player name is not known in debug notifications
The new images weren't supposed to go into 1.14, but the updates to the existing two hut images can remain.
This partially reverts commit a55e5228b2ea0248cee7cd78ee35d26cb407536e.
(cherry picked from commit 556d9ffb91cdf0376336366c1176009169dd6d5b)
[ci skip]
At no point is "generated" checked for as value of that key (the only valid value is "yes").
"generated" is a valid value for sort_topics, however. As for whether we want sorting or not
for Eras, I don't think so. The era order as displayed seems logical enough since it groups
each era and Age of Heroes variant together.
(cherry picked from commit 6b20ccdb6282084b1fdb446d8a93d621204e8408)
It does support id though, which is used as a sort of caching mechanism
in case the same effect is applied many times, so use that instead of name.
For good measure, also use an id on the sceptre of fire animation
The playlist macros set the music list twice, once before the
story screen and again in prestart, but the order of tracks is different.
This means that the track order at the titlescreen and in the lobby is now the same
as the track order in a scenario using the default playlist, which previously was not the case.
Similarly, the track order in the editor is now the same as the track order
in a scenario using the full playlist.
Whether that actually matters? I have no idea. I doubt it.
In any case, as of this commit, there are no schema validation errors
at the title screen, when entering the MP Create screen, or in the map editor.
The error message was, upon opening the page:
```
Parse error when parsing help text: 'Error when parsing help markup as WML: 'Unexpected characters after variable name (expected , or =)
at <unknown>:2''
```
The <bold> tag in question can be seen on old_master_20181015 here:
71a6daf961/data/core/help.cfg (L199)
