Jérémy Rosen
d706fcb2cd
fix bug 18685 and avoid reopening bug 18792
2011-10-19 21:58:08 +00:00
Anonymissimus
00fdec97df
fix a devision by zero (bug #18795 )
...
There seem to be more possible cases in this whole algorithm.
2011-10-19 20:01:56 +00:00
Anonymissimus
c26f9ac9ed
fix $this_unit being broken for recall list units (bug #18821 )
...
Remove duplicate storing, which was clearing the already stored
unit from the gamestate variables again. Silene forgot to delete
the line in 2010-08-06T17:31:14Z!guillaume.melquiond@gmail.com.
2011-10-18 23:19:33 +00:00
Anonymissimus
2ec11831aa
made $this_unit in [unit][filter_recall] work (bug #18168 )
2011-10-18 23:19:08 +00:00
Anonymissimus
34d9b749d7
introduce a member variable in class unit holding filter_recall information
...
Simplifies code and is automatically kept upon unit advancement.
2011-10-18 23:18:48 +00:00
Anonymissimus
d71d48f510
fix variable substitution on [unit][event] and [unit][filter_recall]
...
The unparsed vconfig from the [unit] tag is passed to the unit
constructor and filter_recall and event tags are taken from it.
[side][unit] did already no variable substitution, wesnoth.put_unit does
it only if passed a vconfig userdata to describe the unit.
2011-10-18 23:18:05 +00:00
Ignacio R. Morelle
9e4b0f19a1
Fixed "error parsing image modifications" message...
...
...caused by subsequent image mod additions using the add attribute in
[effect] apply_to=image_mod
2011-10-18 01:03:25 +00:00
Ignacio R. Morelle
077803dfa8
Give test scenario saves a proper internationalized...
...
...(and properly capitalized) campaign type label
2011-10-18 00:32:05 +00:00
Ignacio R. Morelle
a7b8a743f0
Fix inconsistent capitalization of "replay" in the Load Game dialog sidebar
2011-10-18 00:27:23 +00:00
Ignacio R. Morelle
d99194e75e
Use Title Case wherever appropriate in Preferences
2011-10-17 20:18:54 +00:00
Anonymissimus
919d3a9333
remove unit::set_game_context
...
since it's no longer the only place where game context is set
2011-10-17 17:21:55 +00:00
Anonymissimus
5a5606e011
use empty() instead of comparing with an empty string
2011-10-17 17:21:38 +00:00
Anonymissimus
7215ca1920
reintroduce support for [unit][event]s (fix for bug #16259 )
...
Such events are required a non-empty id=.
2011-10-17 17:21:22 +00:00
Anonymissimus
fa8f56b63a
rewrite game_events::add_events
...
to optionally filter by event id whether to add an event
2011-10-17 17:21:04 +00:00
Ignacio R. Morelle
b9dd12178b
Apply "Setting to ignore encountered_units" (patch #2940 by negusnyul)
...
The preferences entry name and tooltip are not the same as the patch in
the tracker, as we discussed on IRC that this doesn't exclusively affect
mainline units nor does it need to. I also changed the tooltip wording
to fit as much as possible in my 1280x800 screen without changing the
font size (works on 800x480 with a smaller font size).
2011-10-16 20:59:09 +00:00
Ignacio R. Morelle
b0e6c09d23
Remove some previous asymmetric behavior kept (not introduced) in 2011-10-16T16:26:07Z!shadowm@wesnoth.org
...
The behavior in question was apparently put in place to avoid a
segmentation fault due to unchecked access to a vector's first element;
ensure there'll always be a first element instead.
2011-10-16 16:43:17 +00:00
Ignacio R. Morelle
75920c02ce
Fix mangling of image path functions...
...
...in credits background lists (about.images attribute) by using the
parenthetical split algorithm instead
2011-10-16 16:26:07 +00:00
Steven Panek
83ad4d41ea
Improved an error message.
2011-10-16 01:27:56 +00:00
Mark de Wever
0312529429
Remove the assert introduced in 2011-10-15T18:06:24Z!koraq@xs4all.nl.
...
anonymissimus found some valid cases which now assert. Changed it in a
debug warning, mainly to have hint that it might be the cause of an
issue.
2011-10-15 21:36:45 +00:00
Mark de Wever
8e03231312
Remove some old-style-casts.
2011-10-15 18:06:52 +00:00
Mark de Wever
e35de2a8a7
Remove some old-style-casts.
2011-10-15 18:06:49 +00:00
Mark de Wever
e63088ad51
Remove an old-style-cast.
2011-10-15 18:06:46 +00:00
Mark de Wever
01a578dac8
Remove an old-style-cast.
2011-10-15 18:06:43 +00:00
Mark de Wever
72a41e4a58
Remove an old-style-cast.
2011-10-15 18:06:40 +00:00
Mark de Wever
d5c260c608
Strip trailing whitespace.
2011-10-15 18:06:36 +00:00
Mark de Wever
c9cf48b676
Add some extra validation before deferring.
2011-10-15 18:06:33 +00:00
Mark de Wever
087e711106
Removing trailing underscores of public members.
...
Trailing underscores are used for _private_ members.
2011-10-15 18:06:30 +00:00
Mark de Wever
eb948eac6b
Remove whitespace.
2011-10-15 18:06:27 +00:00
Mark de Wever
af7ef732bd
Harden unit_movement_resetter class.
...
Add a warning regarding its usage and test whether the unit exists
before assigning to it. (Still a bit experimental, but initial tests
show no regressions.)
2011-10-15 18:06:24 +00:00
Mark de Wever
9a44eaaa76
Add unit_map::has_unit().
...
This allows to check whether a unit exists in the map.
2011-10-15 18:06:19 +00:00
Alexander van Gessel
d1323f29f9
Restore 2011-09-29T15:55:37Z!thonsew@yahoo.com by thonsew:
...
Fixed a std::string & bound to a temporary rvalue.
2011-10-15 17:44:06 +01:00
Anonymissimus
ed3cc61416
Fixed usage of a reference in a commit of mine.
...
According to a comment by mordante in variable.hpp, std::string& foo =
vcfg["foo"] is unsafe, and silene appears to have always used
config::attribute_value foo = vcfg["foo"] (without reference).
2011-10-15 15:52:18 +00:00
Mark de Wever
a9d25133a3
Add a work-round for bug #18534 .
...
The destructor of the class restored the moment of the units. When a
unit no longer exists it overwrites random memory. The issue has been
found by valgrind.
anonymissimus tested the work-around since he was able to reproduce the
issue easily, while on my system it went well for a long time.
2011-10-15 13:29:16 +00:00
Mark de Wever
62922d1144
Remove a no longer needed work-around for g++-4.7.
...
The current snapshot of 4.7 compiles fine without the work-around.
2011-10-14 19:33:25 +00:00
Steven Panek
d085cd4a75
Cover the Kana Supplement block.
2011-10-14 17:08:29 +00:00
Steven Panek
553f02f47a
Don't break before the characters in the Katakana Phonetic Extensions plane.
2011-10-14 16:30:19 +00:00
Steven Panek
d1ddda11f6
Cover Yi Radicals and Yi Syllables.
...
The Yi script is lumped with the other CJKV stuff, the characters are
fullwidth, and so forth.
2011-10-14 16:05:29 +00:00
Steven Panek
af3773af49
Cover Katakana Phonetic Extensions too.
2011-10-14 15:03:49 +00:00
Steven Panek
42abf10144
Made an escaped character consistent with the others.
2011-10-14 14:41:27 +00:00
Steven Panek
7070f64d43
Cleansed parts of is_cjk_char.
...
Cover Hangul Jamo, Hangul Jamo Extended-A, Hangul Jamo Extended-B,
Bopomofo (for realz, this time), and Bopomofo Extended.
2011-10-14 14:36:33 +00:00
Alexander van Gessel
f5b5656a2e
Fix an obsoleted-at-commit comment.
2011-10-14 00:43:09 +01:00
Alexander van Gessel
4a37f70136
Add option --language/-L to select language for that session.
2011-10-13 19:25:06 +01:00
Alexander van Gessel
ebe4e5e357
Make the create unit dialog use valid genders for the unit type (bug #18704 )
2011-10-13 16:04:27 +01:00
Steven Panek
9767281cba
Removed a reference to an obsolete tag.
2011-10-13 03:22:11 +00:00
Anonymissimus
ac8cdfd23e
exposed config::debug() in the lua interface
...
The functionality is actually covered by the dbms function
I wrote in the WLP, but may be easier to find and use. It would have
been useful for me at least, until I had written that function.
2011-10-12 21:44:42 +00:00
Alexander van Gessel
328ab64d6f
Partially restore 2011-09-29T15:55:30Z!thonsew@yahoo.com, which fixes bug #18745 .
...
This version is flawed though, and does not yet work for female units.
2011-10-12 17:41:16 +01:00
Steven Panek
9ec3fe6e7b
Added missing references to liminal,
...
...thus we can now change a unit's alignment to liminal with :unit.
2011-10-12 16:26:28 +00:00
Steven Panek
aac683518b
Corrected micro symbol.
2011-10-11 07:00:14 +00:00
Anonymissimus
d0c72588a9
convert line endings from my previous revision to LF (sry)
2011-10-10 19:14:35 +00:00
Anonymissimus
66463b4f61
manually redo commits related to an event handler bug:
...
2011-09-26T13:17:16Z!anonymissimus@arcor.de
2011-09-26T13:17:32Z!anonymissimus@arcor.de
2011-09-26T13:17:47Z!anonymissimus@arcor.de
(fix for bug #18695 and bug #17527 )
2011-10-10 19:03:48 +00:00