Commit Graph

47943 Commits

Author SHA1 Message Date
Gabriel Morin
aef888dff6 Correct crash with planning a move followed by an attack. 2011-11-23 13:40:23 +00:00
Gabriel Morin
561b14dde0 execute_all_actions returns true if the action queue has been emptied. 2011-11-23 13:40:17 +00:00
Gabriel Morin
89b4d6e33a Don't tell the player "you haven't started your turn yet"...
...when he has some planned actions, and correction of other similar
warnings.
2011-11-23 13:40:11 +00:00
Gabriel Morin
7ec2d52a08 Don't show "Press t to continue" if we're executing a whiteboard move. 2011-11-23 13:40:05 +00:00
Gabriel Morin
54b151c075 Added is_executing_actions() method to whiteboard 2011-11-23 13:39:59 +00:00
Gabriel Morin
68a8077376 Changed an assert into an error in the log, and More logging. 2011-11-23 13:39:53 +00:00
Gabriel Morin
587f2e8240 Logging. 2011-11-23 13:39:45 +00:00
Gabriel Morin
bd6e8c1e7c Deferred a potentially problematic action validation. 2011-11-23 13:39:39 +00:00
Gabriel Morin
d534027eaa Much simpler and faster method of verifying current path of a planned move.
This paves the way for merging mapbuilding and verification.
2011-11-23 13:39:30 +00:00
Gabriel Morin
451b902b25 Added operator== to pathfind::marked_route::mark struct. 2011-11-23 13:39:24 +00:00
Gabriel Morin
61d8129aeb Added a todo about marked_route being incorrectly used. 2011-11-23 13:39:19 +00:00
Gabriel Morin
0a730566ee A little more exception-safety 2011-11-23 13:39:13 +00:00
Gabriel Morin
be493732d9 finalizer struct to help with exception safety:
sets variable to value on destruction
2011-11-23 13:38:55 +00:00
Nils Kneuper
47fc81972a pot-update (preparing for 1.9.11)
regenerated doc files
2011-11-23 13:13:10 +00:00
Elvish_Hunter
18ab6e4e58 SoF: fixed two bugs
Rugnur was recalled unhealed, and sighted events were not fired correctly.
2011-11-23 11:49:49 +00:00
Gabriel Morin
da44706154 Added current known whiteboard bugs to release notes. 2011-11-22 12:04:51 +00:00
Gabriel Morin
5502e6b999 Added a todo. 2011-11-22 11:45:41 +00:00
Gabriel Morin
96a43a48ee Temporarily disabled code that used the pointer...
...to an action's unit before that action was validated, causing segfaults.

Probably related to bug #18534 and bug #18992.

This causes a regression in functionality in the accurate display of
movement points for planned moves.
2011-11-22 11:45:33 +00:00
Gabriel Morin
9974a45ec8 Initialize shared pointers properly. 2011-11-22 11:45:24 +00:00
Gabriel Morin
c0db81e553 Addition of a lock to scoped_real_unit_map...
...to enforce the non-activation of the future unit map.

This prevents code called from WML events (drawing code, among others)
from building the future unit map.
2011-11-22 11:45:13 +00:00
Gabriel Morin
5fd7b794fa Reworked the notifications sent to the whiteboard when game state changes.
Removed a redundant assert.
2011-11-22 11:45:01 +00:00
Alexander van Gessel
a2e3b19256 Revert 2011-11-21T04:32:39Z!ai0867@gmail.com.
This restores the race between error messages and disconnections.
2011-11-21 22:28:47 +01:00
Alexander van Gessel
5571d37008 Move seed erasure before new password request 2011-11-21 19:27:21 +01:00
Alexander van Gessel
87e7950ed2 Swap two arguments of the failed login logger.
This fixes the single-failure-causes-ban issue.
2011-11-21 18:02:12 +01:00
Nils Kneuper
6cbb02d268 updated Galician translation 2011-11-21 11:23:38 +00:00
Alexander van Gessel
fcb260ad95 Flush buffers when closing a funtioning socket.
This fixes a race between error messages and disconnections.
2011-11-21 05:32:39 +01:00
Elvish_Hunter
fc8464158b [harm_unit]: reworked damage calculation code to fix a bug,
where the private unit can be influenced by units with leadership and
cast more damage than expected
2011-11-20 20:09:13 +00:00
Mark de Wever
d3066dd4c3 Remove duplicate tests.
Issue discovered by cppcheck.
2011-11-20 18:51:53 +00:00
Mark de Wever
36a6cb268f Remove duplicate tests.
Issue discovered by cppcheck.
2011-11-20 18:51:50 +00:00
Mark de Wever
b22e8e5b7f Remove a duplicated std::ios_base::binary.
Also some minor formatting cleanup. Issue discovered by cppcheck.
2011-11-20 18:51:45 +00:00
Elias Pschernig
5a2a2fac95 [wmlunits] Fixed forest tile picture. Fixed inclusion of addon campaigns with only shared units. 2011-11-20 15:04:52 +00:00
Gabriel Morin
5fd7b7325b Revert revision #51485 "Add a work-round for bug #18534."
since bug #18534 is now fixed.
2011-11-20 08:08:54 +00:00
Gabriel Morin
3b8b653860 Added asserts to ensure game events...
...and other gamestate-changing stuff never happen while future unit
map is active.
2011-11-20 08:08:48 +00:00
Gabriel Morin
9e2986ad6f Ensure future unit map isn't active while "select" event is being fired.
The map was being modified before the whiteboard got the occasion to
restore the game state.

Fixes bug #18534
2011-11-20 08:08:39 +00:00
Gabriel Morin
2709428b72 Revert revision #52012 "add workaround for bug #18992"
Fixes bug#17277 again.
2011-11-20 08:08:33 +00:00
Gabriel Morin
c145812a2a Don't build planned unit map if whiteboard is disabled.
(Really) Fixes bug#18992.

Relatively minor side effects if you plan an action then toggle out of
planning mode:

- for moves the location that displays the unit in the sidebar will
  switch from future to current position

- for recruit/recall, your real current money will be displayed (could
  actually be considered a feature, you can switch between
  real/projected money with tab)
2011-11-20 08:08:25 +00:00
Fabian Müller
c272984dc8 Don't try to add the leader specific recruit list from a null pointer.
Workaround for bug #18984
2011-11-20 03:55:44 +00:00
Steven Panek
4a0e06cc6d Updated the British English translation. 2011-11-20 00:57:12 +00:00
Steven Panek
4567b50ce5 Updated the Old English translation. 2011-11-20 00:30:22 +00:00
Alexander van Gessel
fd2d8c58ca Dutch translation update 2011-11-19 23:54:40 +01:00
Steven Panek
e1a0efbffb Added missing commas to the changelogs. 2011-11-19 20:48:59 +00:00
Nils Kneuper
da84775513 fix changelog to 80 chars per line 2011-11-19 19:07:04 +00:00
Nils Kneuper
11bdea233f updated Italian translation 2011-11-19 19:05:48 +00:00
Simon Forsyth
7784272c65 Allow 2x2 mountains/volcanos to be drawn at right map edge. Fixes bug #19024 2011-11-19 17:24:14 +00:00
Elvish_Hunter
0ad2329190 Fixed color adjusting in 24-hour ToD to match default schedule 2011-11-19 10:51:04 +00:00
Elvish_Hunter
5f337d13bc SoF: fixed two bugs in A Bargain is Struck 2011-11-19 09:55:08 +00:00
Anonymissimus
b66aa5d275 add workaround for bug #18992
This comments out a part of the offending revision 2011-09-11T00:35:26Z!gabrielmorin@gmail.com by gabba.
(bug #17277)

More explanation see in the bug threads.
2011-11-18 19:59:05 +00:00
Anonymissimus
3c793eb445 add a built configuration to MSVC for detecting memory leaks
defining HAVE_VISUAL_LEAK_DETECTOR, other settings copied from
Debug configuration, so people aren't required to include vld.h
2011-11-18 19:58:47 +00:00
Anonymissimus
48981793e6 mute memory leak warnings about static pointers initialized with new 2011-11-18 19:58:31 +00:00
Anonymissimus
7aaa729698 add a conveniant way to detect memory leaks in Visual Studio
#ifdef'ed out for other built types.

MSVC's built-in memory leak detection is of limited capability due
to conflicts with placement new and missing stacktraces or even line
numbers.

This method uses the Visual Leak Detector http://www.vld.codeplex.com
LGPL'ed; I recommend setting StartDisabled = yes and
AggregateDuplicates = yes. This reduces a bit the noise caused by
static pointers initialized with new. There are a lot of leaks
reported for which I don't know whether they are some sort of false
positives.  I hope they vanish once that someone cleans up the
valgrind log. :)
2011-11-18 19:58:13 +00:00