The text is now shown at exactly the same place regardless of which side
the portrait is on.
Fixes#1938.
(cherry-picked from commit fc9e5f0484bf4718390ed3ab01d5ae418f9cfacf)
- Improve Konrad's line
- Use variant portraits for Konrad and Li'sar
- Update the mage's dialog to match the dwarf's
(cherry picked from commit f7d8d0d25723e84f5fb2cf1a4a5343c263090410)
(cherry-picked from commit 15acd756361a907b9796450f0dd0560b7b20b78b)
Gameplay is not affected. The player can still lose units to {EXPAND_LAVA}.
(cherry picked from commit a3be91248753f9ddbc0d647a4d918e4f160b7d56)
(cherry-picked from commit de9541fd76fca9bd50e4bc71b85b2c95ded0e134)
previously it would cause oos when a player that has not yet advanced to
the currrent scenario sends random seed requests.
(cherry-picked from commit d0c0f406f25ce7a24184e44194b5b22071ebbd53)
Trigger the undead reinforcements even if the player skips the main cave entrance.
(cherry-picked from commit 95b3ccd9fe0ba5f185f749ceac88188be7b591d9)
and make [harm_unit] use these values instead of hardcoded 8*level for
killing and level for combat.
(cherry-picked from commit 3591e82586896c8923de1d45cf9c30d25c522a3f)
unfortunately this adds an annoying const_cast. The old code 'worked around'
this by getting a nonconst reference to the same unit via the unit map,
which i think is not better just hides the issue.
(cherry-picked from commit 08b7d1b1ac2e469bab55c37fe73a40f0df603b04)
The other variables in that event are not needed either, left them in for
readability for the time being.
[ci skip]
(cherry-picked from commit 7a29fc15b4a09837f4eaa2242ab5db4b230f4ef0)
A better image is needed, I remove the darkening overlay, because it would be
missleading when a Mage of Light affects this field.
[ci skip]
(cherry-picked from commit 0ef3c0d5f94f895c65598aee36d9ffde63d5766b)
This prevents the animator from holding a strong reference to the target unit, which was keeping the unit object alive and thus preventing the unit halo, if any, from disappearing.
(cherry-picked from commit 7d6e2b2a10a61e1704c38ea7ee6aa34178a29b38)
The used names was never set so the check for duplicated names did not
work. Detected by cppcheck.
(cherry-picked from commit cc98bcd9d015a852dbec2053f300ce4682c4765d)
Certain distro/compiler combinations will apparently warn about not optimizing when _FORTIFY_SOURCE is set.
(cherry-picked from commit 09fcc6b0519d458cbc3e16788576000a8484020b)
This avoids a reference to the unit from being leaked, which prevented the
unit's halo (if any) from disappearing when the unit died.
Fixes#3509. Closes#3520.
(cherry-picked from commit e63bd35f9d209f355400a743732ea2c4b91d5da4)
The ai_helper functions are optimized for speed (as much as possible in a general setting) and do all the necessary tests. For example, get_units_with_attacks() checks both whether the unit has attacks left, and whether it has any attacks in the first place.
(cherry-picked from commit 75843541bcf92e743b911ef49046c54a050e8a0f)
