We now call get_modification_advances() once (instead of twice). In particular get_modification_advances() can be a rather slow operation for a unit that has many [advancement]s. and xp_color() is called rather often from the drawing code.
In fact xp_color() has caused annoying slowdowns in the past for a certain umc campaign that adds many dummy ( this means: blocked via require_amla by default) [advancement]s to units types. (this was also the reason for 4d73031680 where i found that a lot of temporary t_string objects were created during xp_color/get_modification_advances while investigating that). (that was before the second call to get_modification_advances() was added but well, better to call it once than twice if we know that calling it once was already problem in the past, i even considered caching he result of get_modification_advances() in the past but i currently don't think that's needed anymore, in particular since umc authors have now better options that addong tons of dummy [advamcent]s to unit_types)
Since Travis has support for Windows jobs now, the external CI services Wesnoth uses can be consolidated from AppVeyor and Travis to just Travis.
Fixes#4727
For whatever reason the existing limit of 200MB is no longer enough, resulting in a significant number of cache misses, which results in partial rebuilds taking far longer than they should.
The scons job succeeds due to not passing `-std=c++14` to the linker, as best I can figure, but I haven't managed to be able to test whether this is actually the case because cmake defaults to including all compiler flags with the linker flags and I'm tired of trying to coax cmake to not do that.
This prevents the list's geometry from changing considerably when
navigating into a folder that has no subfolders of its own because of
the lack of icons. We use an empty icon of the same size as the folder
icon for this purpose.
* Units - Dunefolk Nagas - first revisions
* Units - Nagas : rework dirkfang line stats and add a couple dirkfang animations
* Units - Nagas : additions to dirkfang animations
* units - nagas : attack anim tweeks
* units - nagas: melee boost to dirkfang and advancements
* units - nagas: terrain defense boost to ringcaster
* units - nagas - add dirkfang portrait
* units - nagas - revise attack numbers for entire line
* units - nagas - remove reference to old name Dervish in description
* wmlindent run
resolve https://github.com/wesnoth/wesnoth/issues/4718. if other_attack condition for adding of abilitie applied to opponent then abilitie function what for attack to same range what owned by owner of abilitie and weapon like abilities must be applied to all attack matched
For some reason the xcode job easily runs the longest despite being a partial recompile. Having it also be the final job to run therefore means that the entire build will be waiting for it to complete, whereas having it earlier allows other shorter jobs to be run alongside it.
