At some point in the future I'd like to come back and add some search parameters - right now it shows the game history of the currently selected player in the lobby, but ideally it would instead have options for player name, era, scenario, etc.
A couple of functions become private. Although render_texture(viewport)
is dead code I think it's useful enough as documentation to leave it in,
at least until we work out how to fix the crash when trying to show the
long text in the end_credits screen.
The removed render_surface() would be private because it returns a
surface with render-space width and height, however it was also never
called and wouldn't be useful as documentation.
This isn't the complete set needed to allow `check_mixed_indent` to
run over the data/gui directory, it's just these small changes:
* Remove the single space from lines indented "tab ... tab space".
* Convert lines indented with "tab ... tab four_spaces".
Although these are WML files, the coding standard for the data/gui
directory is to indent with tabs instead of spaces.
Turning GLIBCXX_ASSERTIONS adds some bounds checks, such as checking
in std::string::operator[]. It's a subset of the checks that GLIBCXX_DEBUG
adds, but has the advantage that it doesn't require a rebuild of the Boost
libraries.
None of the CI builds enable these assertions, as they slow down the code
which makes the unit tests time out.
This uses tabs instead of spaces, because although that's not our coding
standard, it is only a few lines of changes.
The alternative of running wmlindent on these files changes 4700 lines.
The `[trait]availability=` attribute acts as a part of the parent tag, not as a
part of the trait itself. For example, `[trait]id=fearless` occurs in both the
`TRAIT_FEARLESS` and `TRAIT_FEARLESS_MUSTHAVE` macros, and the trait is:
* Must-have for units: Ghast, Ghoul, ...
* Available for non-leaders of race: Troll
* Available for non-leaders of types: Dune Paragon, HI, ...
Showing a single "Availability:" in the help is therefor misleading. Adding a
detailed list of where it's available adds a lot of code complexity for little
gain; this commit takes the code cleanup and comments from prototyping that,
but just removes the "Availability:" text from the help.
The game crashes when the player clicks the Attack button with
planning mode with a console error about a failed assert on line 164
of src/whiteboard/attack.cpp. The assert uses > but it looks like it
should be >=.
This commit switches from > to >= and appears to resolve the issue.
