66709 Commits

Author SHA1 Message Date
Gregory A Lundberg
c21166cd2f DM S12 Workaround: Primary unit unstable
[fire_event] should use [primary_unit] and [secondary_unit] from the call site unless specifically overridden. Since it fails to do so we have to re-set them explicitly.
2016-10-20 10:49:39 -05:00
Gregory A Lundberg
8c2f8b0a76 DM S12 Fix bug: Warning radius
Using radius is not as clear-cut as people think.
2016-10-20 10:49:39 -05:00
Gregory A Lundberg
7337e963f3 DM Fix bug: No save
Don't make the player re-play a scenario simply to read a cut-screne they skipped.
2016-10-20 10:49:39 -05:00
Gregory A Lundberg
a14d25eba9 DM Fix bug: Grammar 2016-10-20 10:49:39 -05:00
Gregory A Lundberg
984cf52d72 DM S11 Hide sides
No sense giving away that Chantal and the Orcs are here. Wait until Delfador learns of them to expose their sides.
2016-10-20 10:49:39 -05:00
Gregory A Lundberg
e0125ea121 DM S11 Fix bug: Chantal can move
Use a sighted event so Chantal speaks when first sighted, and since she can move from her citadel. Clear a bit of shroud around her.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
2e84f59f76 DM S11 Fix bug: Orc dies first
In the all-but-impossible case the orc leader dies before Delfador finds Chantal, wait until he finds her for victory.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
df785a4535 DM S07 Fix bug: Include advancements
The hint about heavy infantry should appear on advancements as well.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
906cb3b3a4 DM S06 Improve chest
Leave an open chest behind so the player knows they opened it already.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
f7ac9c6251 DM S05 Needlessly delayed 2016-10-20 10:49:38 -05:00
Gregory A Lundberg
68f7c0ec48 DM S04 Fix bug: No scenario-start saved
This means players must re-play the end of S04 if they wany to review the dialog in S05. Allowing the save made the event dead code; removed it all.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
bf24d087ce DM S04 Fix bug: Delfador was the victim
If Deflador is killed by an assassin, he can't speak the line.

There was a TODO here about not liking the conversation. The only real problem was that Leollyn said "I told you .." when he hadn't and that only one friend had died, not several.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
dbcd2e948d DM S04 Fix bug: Include advancements
The comments about Orcish Assassins apply to their advancements, as well.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
ab0c6e5335 DM S04 Fix bug: No defeat
Defeat when Leollyn dies, even if he advances.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
c38b5da9dc DM S04 Fix bug: Best bowman
Recall the best bowman. If we don't have any, recruit them. S03 ensured we had at least one.
2016-10-20 10:49:38 -05:00
Gregory A Lundberg
2d2ac10ba5 DM S03 Fix bug: Include advancements 2016-10-20 10:49:37 -05:00
Gregory A Lundberg
09e7006b1d DM S12 Fix bug: second wave
If the undead have not been spotted, Delfador does not know they're there, so cannot know about the second wave.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
39da9c8f9a DM Fix bug: Subsumed sides cannot move
In S13 we subsume the Loyalists and Mages.

In S19 we subsume Lionel and his troops.

These occur in the midst of battle. The units may be damaged, poisoned, etc. We do not want to change that.

However, since their turn follows ours, they cannot move. Reset their moves to maximum so we can use them (or move them out of harm's way) immediately.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
f86630273e DM Debug/Next_Level fix
Split off a victory event which ensures needful things happen on debug next_level.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
76b549987c DM Align teams and team names
Use 'allies' and 'enemies' consistently, throughout.

Delfador's team names are, in order: Mages, Loyalists, and Rebels. All Undead are a team; as are Bandits. Goblins, Orcs and Trolls are the Pillagers. The NPC Loyalists switch from allies to enemies, but remain Loyalists throughout.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
f8358bdfb3 DM Hide unneeded sides
S08 Side 3 is an implemention detail which the player does not need to see.

S08 After Delfador is struck and fading to black, hide all sides to enhance the player's impression Delfador has died. There are no sides left on the map, anyway.

S09 After the undead join Delfador, their side no longer exists.

S11 After Chantal joins Delfador, her side no longer exists.

S12 When the Loyalists and Mages join Delfador, their sides no long exist.

S17 After Ulrek joins Delfador, his side no longer exists.

S19 When Lionel joins Delfador, his side no longer exists.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
430d19569b DM Make heros
Consistently mark all non-leader units for whom death is a defeat condition.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
d1c6a4ab0c DM Fix bug: Kalenz takes over
Kalenz should take over a no_leader side, have his unit brought in as a [unit] tag, and his unit should not have side attributes.

This caused a number of errors in stderr, including dumping the full WML for the scene.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
8d3894a565 DM S21 Fix bug: Incomplete objectives 2016-10-20 10:49:37 -05:00
Gregory A Lundberg
cb1fd2ce2c DM S20 Delfador's been busy, too
Bump Delfador a level when he reappears to drag Eldred back to his father.
2016-10-20 10:49:37 -05:00
Gregory A Lundberg
68483ba984 DM S20 Since you've been away
It's been 26 years. Kalenz, Chantal and the other elves should be in perfect health, and have advanced a level from when last seen.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
6603003e62 DM S19 Fix bug: Kalenz returns in poor shape 2016-10-20 10:49:36 -05:00
Gregory A Lundberg
e59cb908e0 DM S19 Bring out your dead
Recall all Delfador's undead units so he is speaking to all of them when releasing them.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
afe5fc1ca2 DM S19 Kalenz is available
The [if] is meaningless. The death of Kalenz is a defeat; he will always be around on victory.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
7215b4403b DM S19 Fix bug: Defeat on undead death
Defeat should only occur when there are no more undead available to Delfador.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
e83101a785 DM S19 Fix bug: Mismatched shroud
Place and remove the shroud from both sides 1 and 2 consistently.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
17a7664f09 DM S18 Highlight Iliah-Malal
Add leader-expendable and ellipse-hero to mark him. I would have preferred the gold leader overlay but could not find it and making him a leader causes the AI to take him to a keep instead of treating him like any other Lich unit.
2016-10-20 10:49:36 -05:00
Gregory A Lundberg
aaaaa7ee3b DM S16 Fix bug: Unexplained gold 2016-10-20 10:49:36 -05:00
Gregory A Lundberg
0e51165808 DM S15 Chantal already recalled 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
87a0212da4 DM S14 Fix bug: Clear fog around Delfador 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
f62cec9865 DM S14 Fix bug: Rudimil might be dead
Use one of the other leaders to announce the arrival of reinforcements.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
a509035767 DM S13 Fix bug: Chantal moves properly
When last seen Chantal was south-west. Have her enter from that direction and run directly to Kalenz. Originally, she appeared in the middle, ran left, ran right, bumped into the edge and stopped; and, usually, Kalenz would be far away from there.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
4079814228 DM S13 Fix bug: Chantal returns in poor condition 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
971353580c DM S13 Fix bug: Disallow recalls
The play has recalls (although not on the list). Disallowing recalls recognizes this with a more appropriate error message.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
f86b3c99dd DM S12 Fix bug: Inconsistent objectives 2016-10-20 10:49:35 -05:00
Gregory A Lundberg
9faeaf561b DM S12 Fix bug: Arpus may be dead
It is remotely possible Arpus may be dead prior to moving to wake the Mages. In fact, they may all have died. Appoint a replacement from the highest-level survivors (if any).
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
3cf1e5a8e9 DM S12 Fix bug: Niktor may be dead
It is possible Niktor was killed before meeting the loyalists. If so, appoint a replacement from the highest-level survivors.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
c5e60b8460 DM S12 Fix bug: No objectives change
Capturing villages inside the garrison should change objectives if they have not done so already.
2016-10-20 10:49:35 -05:00
Gregory A Lundberg
0229a24e05 DM S12 Fix bug: Objectives already changed
Capturing the village near Delfador's encampment changes objectives. They also change if orcs or undead are seen, or the Loyalists met; but that change is a duplicate. Remove the duplicated change.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
f2d6a00a8d DM S12 Fix bug: Delfador knows about undead
He should not ask about the abominations.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
997887cdde DM S12 Fix bugs: Several errors with Mages
Apparently, the Mage keep was moved. The scroll position was not updated, nor were the AI parameters to keep the Mages near their keep.

The fog does not lift to expose the Mages, and the narrator's instructions are incorrect.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
b5608d032d DM S11 Fix bug: Inconsistent objectives 2016-10-20 10:49:34 -05:00
Gregory A Lundberg
80d15ec198 DM S11 Fix bug: No recruits before Chantal
Delfador should not gain the ability to recruit Elves until he actually meets Chantal.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
fe8d088fd3 DM S11 Fix bug: Chantal defeat
It is remotely possible Chantal dies before Delfador meets her. Remove her death as a defeat condition until he does.

The goal is to find her before time runs out. If she dies before being found, time will run out.
2016-10-20 10:49:34 -05:00
Gregory A Lundberg
e208f01770 DM S11 Fix bug: Disallow recalls
Delfador has recalls (although not on the list). Disallowing recalls recognizes this with a more appropriate error message.
2016-10-20 10:49:34 -05:00