This reverts commit 1d84d83c6c6c70e3c25de6e3d443a7ec17936711.
I had introduced use of the hidden= key in b2df837d8e7a95ae2e15dcbdffbd0653ab481443, but
apparently didn't add them to the valid list of non-aspect keys.
A fix to httt causes fuzzy strings in NR without this change. Tow
options were available:
1) Remove the fix from pofix since it creates false matches
2) Add the fix to the file in NR that also has the issue and apply
pofix to all po files in wesnoth-nr textdomain as well as the pot file
Since it is a "bug" having this grammar mistake in there, I went for
option 2 even though it is string freeze (since it should no longer
cause "false positive fuzzies").
[wesnoth_addon_manager] Allow overriding keys in _server.pbl
Example usage:
wesnoth_addon_manager \
--port 1.13.x \
--upload ~/.local/share/wesnoth/1.13/data/add-ons/example \
--pbl-override version "$(git describe --tags)" \
--pbl-override description "$(cat avoid_copy_paste_with_WML)" \
--pbl-override passphrase "in countrary to server.pbl, this is secret"
Downsides: user has to be aware that specifying
passwords as CLI arguments is not safe in a multi-user environment.
If we're really-really serious about it, we should parse
values from environment variables then..
I wouldn't bother though.
fixes GH-2485
This replaces the broken implementation I added in fb6c85e70b0c012e4ae10edd29354f41725ca6b9.
See documentation in data/hardwired/fonts.cfg for explanation as to why it didn't work and
why this does.
Currently "light" is set to Lato Light, which is weight 300. Regular is weight 400.
To remove an add-on, you now have to use:
--remove ADD_ON PASSPHRASE
instead of:
--password 123 --remove NAME
Also, this commit fixes the badly
documented --password field.
It could previously be read as it can be applied
to any operation, not only removal.
But in fact it could only be used for removal.
Fixes GH-2445
* Some improvements to the messages
* Don't clobber existing metatables on deprecated subtables
* Fix Lua deprecation messages not even being logged
* Fix deprecation of Lua subtables
* Don't clobber the metatable when deprecating a subtable
The previous version caused errors under some circumstances when an
event removed units other than the attacker during or immediately after
an AI attack.
[ci skip]
* Improved leader list display
* Made dialog slightly wider to reduce likelihood of a horizontal scrollbar appearing.
Still not a perfect fix, but it's better.
This dropdown allows the player to sort add-ons by name, author, size,
download count, type, or the time of last update or original upload.
Sorting by the last two hasn't been possible in the GUI2 add-on manager
before.
Closes#1747.
* Flipped the arrow on the Update icon set to point downwards, since it's a download operation.
* Renamed existing small Update icon set Publish, and added downwards version to replace Update.
* Renamed all addon manager icons and their respective button definitions to be clearer.
* Moved unused small icon versions to their own subfolder.
* Added separate Publish inline button to image list. This is now used in all cases to publish,
regardless of whether the addon has been uploaded previously or not. Prior to this, the Install
button was used for non-published addons, and the Update one for published ones. This means the
* Refactor addon_list inline button setup to be clearer.
* Made inline Uninstall button display in all cases where an addon was installed, instead of just
INSTALLED and NSTALLED_UPGRADABLE. It will not display if a publishable addon has not been
published, however.
* Changed is_local check to match the ADDON_INSTALLED_LOCAL_ONLY. I figured this is a bit more
robust. TODO: do the same in the addon manager itself?
Art assets credit to @Lordbob
On this map, side 1 starts at the bottom, while side 2 starts at the top. The naming of the teams assumed the opposite. Another check mark on issue #2453.
[ci skip]
This prevents private chat logs being saved in your preferences file. History isn't
currently working anyway, and it seems weird to be saving logs this way, especially
since it also records private messages.
