I'm not sure how it's possibly useful, but apparently this can be sent by the python client
This reverts commit fdc8d92fe6c38c995e0ef02c7fd219841da41ad8.
Turns out the loss of precision over subsequent uses of subrect results in incorrect rendering, even if you round in point_at.
This makes it a non-member function so it can work with both rect and SDL_FRect as input.
This is mainly for the units dialog code, which hides all the sorters beforehand. I decided to put it here, but in future we might want it to be more targeted, in case it becomes an unexpected side effect.
Even though we direct all intermediate rendering to our own backbuffer, SDL recommends clearing the window backbuffer before drawing to it. I don't know if this changes anything with our usecase, but best to follow their recommendations, since SDL interacts with the underlying display driver.
When TSG was created (and when TSG's PR was created), data/resources did not exist. Now that it does, replace TSG's campaign-specific weather with data/resources.
To fix CI errors, replace the old resource "extra_defines" system with manual includes instead (including in EI).
An encyclopedia revision partially for TSG: Re-Revised:
Explain BF (Before the Fall) in the calendar page. This is not used in mainline, but appears in the game’s code and can be be used by UMC or future mainline content.
Made spacing throughout the encyclopedia consistent.
Added a detail on Mount Morogor being the highest active volcano in Morogor, not just a random volcano. This makes it appear more sensible that it is included.
Added the Island of Gaall and Isle of Omarath to Morogor, shown WoF. IIRC no other islands in Morogor are named in WoF.
Mentioned Kerlath and the Far South at the end of the Wesnoth description.
Removed reference to Blackmore being Wesfolk to prevent contradicting certain add-ons
Clarified Kerlath is the southernmost province in the Westin description, not just a southern province.
Added Southport to the Wesnoth section from the TSG Re-Revision.
Mentioned farmland in the periphery of Elensefar, mostly to fix a minor nagging lore inconsistency where Elensefar is always shown on the island in the Great River in scenario maps, but is shown south of it in the large map of Wesnoth. Since there are usually some village around Elensefar, some farmland made sense.
Removed the Southwood due to its removal from the TSG Re-Revision.
Added the Vale of Blossoming Trees and Lake Aelin to the section on Southwestern Elves.
Replaced "men" with "humans" in the Northlands description, which I accidentally copied from the old description. I see no reason for this not being gender-neutral. (Actually, these small changes could be merged separately earlier)
Mentioned Saurgrath in the Northlands.
Replaced Bay fo Jotha in Jotha’s descriotion with “South of Bitok”
Added a description of the Mourned Hills which mentions Lmarig, as suggested by CelticMinstrel
Added the Acanclave Citadel in the Far North from the MP Map
Remove explicit mention of Dunefolk in the Far South and mainline Isanbar and the Ashland Desert.
Instead of it, other more specific schedules
(BRAZIER_ILLUMINATION_LONG_NIGHT, BRAZIER_ILLUMINATION_SECOND_WATCH,
BRAZIER_ILLUMINATION_MORNING) are used in the scenarios.
1. make the gold color less bright
2. add hover states to radio and checkbox and update disabled state
3. make hover states of language and about button consistent with other buttons (white -> yellow)
This makes it possible to fetch the on-screen coordinates of a drop
down menu item as the menu is dismissed by clicking on it so the
caller can use these coordinates to make a more informed decision as
to where to spawn a submenu, improving the previous mechanism wherein
the submenu would have its top left corner set at the mouse's location
which would produce different results depending on where exactly in
the menu item's box the mouse was at the time the parent menu was
dismissed.
This is basically superceded by --plugin
Though it's supposed to be a script that can control the client, that capability doesn't actually exist in the implementation.
* Make named tuples comparable with == and ~=
* Fix the possibility of the numeric and string keys becoming out-of-syn on assignment
* Fix non-existent numeric keys being treated like a string key
