previously players had to leave an rejoin the game to change their faction.
this was most annoying in coop games where you want might want to choose
your faction in consultation with the other players. Also you previously could
not even checkout the different available factions again after you joined
the game.
(cherry-picked from commit 5ba389111eaa5d08f55d60c1b437c250a329bc58)
[ci skip]
Makes it clear it's not intrinsically tied to the Accelerated Speed factor.
(cherry-picked from commit 10e663ed6ce49974e22d4dab5211716210ead6e9)
[ci skip]
For some reason, this made the entire page stack thinner than it should be. I have
no idea why, and I'm not sure wrap= here instead does anything (namely, wrap if it
gets too long), but it's better than what was happening before.
(cherry-picked from commit cb7a6791421511f4251f2d1cb31a894fa8de90cf)
If the leader hasn't been discovered, the "Unknown Unit" topic will be shown.
Fixes#1491
(cherry-picked from commit a8f83f6e687abe997d33a028f841c0bdd5495a11)
[ci skip]
Really no reason for the text area to grow since the text is set in pre_show and
therefor the widget is always the right size. >_<
(cherry-picked from commit 01d37ca7953f3efdd143f7265ecc94dc01791ebb)
Makes it easier for translators to do something specific with this label if needs
be. I remember the reason the count (NUMx) label was moved prior to the name had
to do with language conventions too, so this should alleviate any other such issues.
Also made the name label default size instead of small.
(cherry-picked from commit 142a2f20ca70deaf4d6a71c918de47aef366fc47)
[ci skip]
This better conveys its behavior, especially with the introduction of the hidden PRNG
preference.
(cherry-picked from commit bf92dbbfd2c1699a9af11e6ddc1b850e154d16f9)
It didn't make much sense to have these since there's really no situation you'd want
the "default" sorting order, which is however the server decided to send the list.
(cherry-picked from commit e754e64987b3be3e97adebe0755f408066b2f41d)
I'm not 100% sure about this change, but I think its presence was rather confusing and
it (hopefully) shouldn't ever be needed.
(cherry-picked from commit fe10bc0315472b49072a39cd577b9872617d81d3)
Also sets the tooltip type for this dialog back to bottom-of-the-screen ones instead
of floating ones. And some formatting cleanup to the C++.
(cherry-picked from commit 851b28e24bfefd068069aa9ac2eaada6593718b4)
[ci skip]
Height isn't the problem. The default lobby can display fine even at 600 px h. Width is
the problem the default layout faces at low resolutions, and it was quite odd to have a
really wide window use the low resolution layout, despite there obviously being enough
horizontal space to fit the sidebar.
(cherry-picked from commit 2f565b8e90e9b49a49635034524eb79d29e5f80d)
[ci skip]
This is currently only the case on the 1.14 server, but it's easiest just to
remove the line completely rather than constantly adding or re-adding it based
on whether you're using a or dev series.
(cherry-picked from commit 6f057d8b02572172209afdf718cbd1bfe50d1016)
[ci skip]
Since these are usually used inline or as key values, we don't need the extra padding.
(cherry-picked from commit 7db83e3a0e5de45b3e64eb1da784a8ce334a49c6)
Previously, I had implemented the hint text ("Search)" and image (the magnifying glass)
as a custom text box definition. This caused some problems, though. Since the string was
hard-coded as part of a WFL formula, it couldn't be translated (see #2709 and #2732). It
also wasn't expandable to any other usecase.
Instead, I've added two new hint_text= and hint_image= keys to [text_box], wrapped the
"Search" text and magnifying image path in a helper macro, and refactored the default
definition to display the hint text and image when appropriate.
This also fixes a minor issue where selected text wouldn't remain highlighted when the
box wasn't focused when using the filter definition (it did with the default one).
This should fix the untranslatable "Search" text issue mentioned in both issues above.
The new string is in the wesnoth-lib textdomain.
(cherry-picked from commit db5abb7e637fd87699fce49a9543faafc3f58068)
Resolves#2748.
Essentially, all this did was tell users to go use the forum, so it wasn't worth
it to keep it and solve the infinite loading screen issues it was causing.
The server backend still needs to be cleaned up.
Also removed a dead reference to some "Change Username" button in the Login dialog's
code.
(cherry-picked from commit ebec4d6ce8fd8e46ce1d8a4bb4f5d04fddd87c72)
* Added textdomain closure missing from 267510ea076ce317d323da54bb81ccd255b93284
* Avoid use of invalidate_layout by having an em dash in the size field prior to
saving. That's needed since GUI2 doesn't expand the label's canvas if its text
is initially empty.
* Use a better button definition for the View button.
* Grouped Save and Close buttons together
