The ability's code in UtBS hasn't changed since 1.16, but there's now a bug about
healing sometimes not working in UtBS S02. The new test was written to check
for an engine bug when a healer has two units next to it, only one of which
passes the filter; although it's passing, it seems reasonable to keep the test.
Also, use `{ASSERT ...}` for better logging in the old healing test.
* Run auto-format
* Avoid broad exception handling.
* Remove unnecessary reference to self.
* Tidy imports.
* Remove redundant brackets.
* Narrow exception handling on unrecognised locale.
* Simplify command construction.
* Simplify command construction.
* Avoid shadowing.
* Spelling corrections.
* Reviewed argument parsing:
* Average user probably won't know that ISO 15897 refers to POSIX locale names.
* 'default' probably isn't an accurate description of the entered locale so change to 'user'.
* Remove the hard-coded usage text - the default usage string from the arguments list is sufficient.
* Use title case for menus as per UI style guide.
* Avoid abbreviation for UI text and add translation notes.
* Reviewed text for the tabs representing options for each tool.
Also removed forced new-lines, which I think are unnecessary.
* Consolidate strings to allow for translation sharing.
* Add translation note
* Use title case for titles.
* End sentences with full-stop.
* Title case for titles, translation note, full-stop.
* Abbreviated error message sufficient - consistent with other error messages.
* Clarify file vs file name.
* The translations directory is referenced regardless of whether the user has specified a locale or not, so put the check for the translation directory outside the user-input condition.
* The function isn't just for the user-specified locale, it steps back to the system locale if no user-input is given for the language.
* Clarified the reason for the code duplication in the set-up for system locale.
* Use en_US for commentary.
* Treat 'normal mode' as just one string.
* Replace empty place-holder with numbered indexes to work around gettext limitation.
* Correct typography.
This doesn't fix the underlying issue with labels trying to show text too long to be rendered, but it does at least make the text show up now.
Fixes#7565, not sure about the other inspector related issues.
If a unit type has male and female versions, then two images of the unit are
displayed at the top-left of the help page. However, it did this even if the
two images were the same, which made the duplication look like a bug.
The Naga Fighter is one of the affected unit types.
super="units/unit_type/abilities/~generic~" isn't quite accurate since there are a lot of keys/tags in there that may not mean anything for dummy abilities. Probably doesn't hurt to expect they work like in mainline though.
Levels have been normalized a little to scale smoothly. This combines
the old 1.25x and 1.5x zoom levels into a new ~1.41x zoom level.
Others are more-or-less unchanged, other than modification for the
requirement that scales are divisible by 4.
Also changed zoom level specification to direct integer sizes rather
than multiplication factors, so they can be specified accurately.
It has always been the case that they were required to be multiples
of four. This was just violated at some point.
This fixes problems with overlapping fog textures at some zoom
levels, and may also prevent some other rendering glitches.
A new fake video mode video::fake::hide_window was added,
as screenshots need a rendering context and thus a window.
It draws everything as normal, just with the window hidden.
The other fake modes were also renamed to increase clarity a bit.
