we now enable warning 4800. I ran though the msvc compile with this
warning and i found some (in overlay.hpp, unit.cpp, whiteboard/move.cpp)
unintended implicit bool b = cfg["attributename"] casts that use
the implicit attribute_value to int cast and then a int to bool cast.
So for attributename=true b would be false. So i believe this
is a useful warning.
There are also a lot of implicit int to bool cast from the SDL and LUA
C-libraries which use int instead of bool because C doesn't have bool.
In this case this warning is less useful, but i still think it's worth
it since a "!= 0" or "== 1" isn't cost.
Plus if someone really wants to disable this warning he can still
disable it in the msvc project settings, while before is was not
possible for someone to enable this warning the the settings.
Now that MSVC 6 is no longer supported start to remove some helper code to work
around problems in that compiler. The first step is to comment out the code and
replace it with new helper code that uses the standard. The second step is to
remove the helper code and fix all callers.
Patch 1/3 for step 2: Clear global.hpp, but add some MSVC9 workarounds.
...to work around problems in that compiler. The first step is to
comment out the code and replace it with new helper code that uses the
standard. The second step is to remove the helper code and fix all
callers.
Patch 1/3 for step 1: Comment out global.hpp.
-fix del_tags to span multiple lines
-new method nullify_markup to display error messages containing '#else', etc
-fix an iterator redefinition in the animation code
-add lots of global std namespace fixes for MSVC
* Wesnoth is distributed under the terms of the GPL version 2, made
that more explicit
* updated the copyright range to 2007
* updated Dave's email adress
