This was never finished, is not maintained, suffers from a lack of features the "old" listbox
class now has, and seems (according to the logs) to be have been superceded by the pane widget.
At the very least, the pane widget seems to be what mordante was working with in his early
prototype of a new addon manager, and not this 2010 list class.
(cherry-picked from commit 458dd284b8342b33e6a6359aefbbbdb386b28875)
primary reason is rather to have less problems if
someone uses the master files when translating for 1.14
[ci skip]
(cherry-picked from commit 9a37fe3a072ecd15ba8e196adcfac7e6a12e5444)
this also fixes a bug where the side number in the initial flg dialog would be off by one.
This is also a slight behviour change where not finding [era] in mp_join_game::fetch_game_config no longer throws config::error but just returns false (=cannot join game)
(cherry-picked from commit a2a4dff050713e96b0b14612486d82cf3f93fa3d)
we cannnot call show_flg_select from inside the select_leader_buttons callback because that select_leader_buttons might be deleted/recreated while that dialog is open whihc leads to crashes, so what we do is executing the show_flg_select
in a seperate callstack by using a 0 ms non-repeating timer
(cherry-picked from commit c55512755237dc818abc3b6bce4c3d31dbd2449b)
in the non-host case the clients might get updates that change the [side] config while the flg dialog is open which might result in invalid pointers, note that flg_manager::default_leader_cfg_ is still there but this is no problm because that is never dereferenced it's only compared to other pointers.
we also make a copy of all [multiplayer_side] on the non hosts side for the same reason.
(cherry-picked from commit c805897797d7ff22f3ea4fd1ce9c0fb126baefea)
previously players had to leave an rejoin the game to change their faction.
this was most annoying in coop games where you want might want to choose
your faction in consultation with the other players. Also you previously could
not even checkout the different available factions again after you joined
the game.
(cherry-picked from commit 5ba389111eaa5d08f55d60c1b437c250a329bc58)
Also confirmed via PM with beetlenaut that they can be removed, and aren't supposed to still be there.
(cherry-picked from commit 649fdc9a6204cc4e2019aac41a79910b493b7d5a)
[ci skip]
Makes it clear it's not intrinsically tied to the Accelerated Speed factor.
(cherry-picked from commit 10e663ed6ce49974e22d4dab5211716210ead6e9)
[ci skip]
For some reason, this made the entire page stack thinner than it should be. I have
no idea why, and I'm not sure wrap= here instead does anything (namely, wrap if it
gets too long), but it's better than what was happening before.
(cherry-picked from commit cb7a6791421511f4251f2d1cb31a894fa8de90cf)
This avoids an issue where people could still apply formatting by using an older client.
Granted, any formatting would still appear in-lobby to anyone using an older client, but
this at least prevents the possibility of formatting appearing indefinitely if a game host
happens to never update their own client.
(cherry-picked from commit 9c311e2ca5db1f2b53570ae5bc0681f574c66f9d)
This is a good point since it ensures any place that might use the title before the lobby
(don't think there's any such places right now) won't inadvertently get formatted.
Also might be worth looking into a way to just strip formatting completely.
(cherry-picked from commit 58a2e23a0c78078844f7fc2d684f04f448081f8b)
Fixes wmllint crashing like this upon encountering a gzip tarball in an
add-on:
Traceback (most recent call last):
File "/home/shadowm/bin/wmllint-1.14", line 3188, in <module>
for fn in allcfgfiles(directory):
File "/home/shadowm/bin/wmllint-1.14", line 2944, in allcfgfiles
if interesting(os.path.join(root, name)):
File "/home/shadowm/bin/wmllint-1.14", line 2927, in interesting
return fn.endswith(".cfg") or is_map(fn) or issave(fn)
File "/home/shadowm/src/wesnoth-1.14/data/tools/wesnoth/wmltools3.py", line 270, in issave
return firstline.startswith("label=")
TypeError: startswith first arg must be bytes or a tuple of bytes, not str
[ci skip]
(cherry-picked from commit c92e167a14229ed0d9b6f16f1d1ca31cacd292cd)
this would bring the whiteboard data of the differnt clients out of sync which could be a problem since the wb network protocoll identifies the actions to be removed ot replaced by index.
(cherry-picked from commit 3a28c3a3460aaff0d59826f401623dad8ecadb3f)
Fixes: https://forums.wesnoth.org/viewtopic.php?f=21&t=48370
In the tutorial when we occupy the first village the message tells us the
village count got incremented, but in the old version it was incremented
only afterwards. Non-narrator messages were updated properly. By adding the
redraw, narrator messages triggered by capture event produce the same
result as other speakers.
(cherry-picked from commit 1ea4149a4456ab8713dde4fbfcdd446b5762adcf)
There are only 3 places where it's actually really needed. Used the game_config_manager
singleton to retrieve a reference in those cases.
(cherry-picked from commit 4eee386664b66e801bd4498e8730c017af03f0aa)
This makes it so addon metadata (title, version) will be fetched from _server.pbl if
present and _info.cfg if not (see #3278).
This also eliminates the temporary addon_source struct and unifies the metadata parsing
and actual loading stages. They used to be separate since single-file addons were a
thing, but those were removed in 3f640b8e718e4c45d8f73798d839bfea0b413fab.
Also a bunch of minor code cleanup.
(cherry-picked from commit cd3c13aca223e8a8c681556fe8020915d98058e0)
This reverts commit c93482560779c0e137d9598b9e7185338afe2b82.
Keep data/test/ in 'scons dist' tarballs to match official tarballs.
(cherry-picked from commit bad6897cbc75225624814b66c9226cf6233e95cf)
This makes 'scons dist' work, although the resulting tarballs are not
yet identical to cmake tarballs.
Remove awk usage made obsolete by the git transition
(7f85fa000c836c27cfe9d829db3b0e8aaeb49821).
Update src/revision.hpp reference to use src/revision.h. The former
name is unused since at least 7625b1e079b470119d72ea67ce955104f464e4b8.
(cherry-picked from commit 0ee485415710288d27f7b766e48fe7451b03c9a4)
