67663 Commits

Author SHA1 Message Date
Charles Dang
d46d8c3cb8 Addons List: removed border around containing listbox
Widgets usually leave it up to the dialogs to provide a border. Since this entire widget is wrapped in
a listbox, there's no need to adjust any internal borders.
2017-02-20 13:53:51 +11:00
gfgtdf
0b159f21eb add some debug output 2017-02-19 23:06:06 +01:00
gfgtdf
6fb765a7aa add a comment 2017-02-19 14:37:13 +01:00
gfgtdf
54593675f2 Add an alterntive redo code (#934)
that is simpler and doesn't require wml developers to use [on_redo], wrapped in a preference switch since its not completeley tested yet.
2017-02-19 04:21:42 +01:00
gfgtdf
469046778a add a fixme comment 2017-02-19 04:05:46 +01:00
Charles Dang
ad47ae901a Addons Manager: tweaked UI filter labels 2017-02-19 07:26:15 +11:00
Jyrki Vesterinen
8be7de39f9 Fix checkbox dropdown not saving choices made by clicking the rows
The fix is to simply call the state change callback even if the state
change was invoked programmatically.
2017-02-18 22:10:57 +02:00
Charles Dang
c4cb783772 Fixup e0abb21 2017-02-19 06:54:29 +11:00
Jyrki Vesterinen
693e4b4f87 Filter the list immediately when the player ticks/unticks checkboxes
Don't wait for the player to close the dropdown first.
2017-02-18 20:59:37 +02:00
Charles Dang
e0abb21176 Addons Manager: add notification if no addons are available 2017-02-19 05:27:37 +11:00
Jyrki Vesterinen
74aa2b6983 Fix build with Visual Studio
I also fixed a compiler warning.
2017-02-18 20:22:02 +02:00
Charles Dang
0e1d6df91a Addons Manager: use 'keep open' behavior for type filter dropdown 2017-02-19 04:15:21 +11:00
Jyrki Vesterinen
979637fb70 Add-on manager: implement filtering by type 2017-02-18 18:41:31 +02:00
Charles Dang
a0454f95e9 IPF: use a unique_ptr to automatically handle the deletion of mods in a queue
NOTE: the empty destructor was removed since a dtor prevents the compiler from generating a move constructor,
which is needed in this case so the modifications::decode function works.
2017-02-19 03:21:54 +11:00
Jyrki Vesterinen
ef6b57aa25 Fix build with Visual Studio 2017-02-18 17:47:17 +02:00
Charles Dang
993a760b4e IPF: replace usecase of C-style fptr 2017-02-19 01:33:14 +11:00
Charles Dang
76d6687c0b Removed the GUI1 color2markup formatting function
Unused now with the removal of the GUI1 addons manager
2017-02-19 01:20:17 +11:00
Charles Dang
dec7c30644 Removed GUI1 scrollpane class
Not sure when this became unused, but it is now.
2017-02-19 01:14:02 +11:00
Charles Dang
8a5274c39b Removed GUI1 addons manager 2017-02-19 00:52:49 +11:00
Charles Dang
1c4102abad Addons Manager: only reload cache if needed 2017-02-19 00:40:36 +11:00
Charles Dang
b11ff9689b Minor code and formatting cleanup to IPF code 2017-02-19 00:25:31 +11:00
Celtic Minstrel
3df8d4f4dd Merge pull request #929 from sigurdfdragon/add_new_keys_to_store_side
WML: Add additional members to [store_side] results
2017-02-17 22:24:53 -05:00
Charles Dang
ff93e64f76 IPF: move simple class member getter implementations to header 2017-02-18 10:32:21 +11:00
sigurdfdragon
8cbd084fc5 Add changelog entry for updated [store_side] 2017-02-17 16:54:38 -05:00
sigurdfdragon
7a371c156b WML: Have[store_side] use .__cfg from wesnoth.sides 2017-02-17 16:54:37 -05:00
Charles Dang
68a500df7f Update tests for fd3b71f 2017-02-18 03:02:44 +11:00
Charles Dang
fd3b71f88b Completely removed the ~LIGHTEN and ~DARKEN IPFs
These did not do what one could reasonably expect them to do and in any case, a simple ~BLIT should suffice.
2017-02-18 02:58:34 +11:00
gfgtdf
86e1bdd2a1 fix compilation error 2017-02-17 16:07:16 +01:00
gfgtdf
160b3e79c5 add another assert to check refcount
to check this against memory corruption.
2017-02-17 16:01:10 +01:00
gfgtdf
26020fe93f add an assert to check refcount. 2017-02-17 15:57:03 +01:00
ln-zookeeper
9359a91c5d Small tweaks to mountain and hill transitions 2017-02-17 11:29:41 +02:00
ln-zookeeper
e3ccff10c4 Disabled base transitions for the stone/straight walls (Xo*) 2017-02-17 11:16:29 +02:00
Charles Dang
8e1ca91e41 Menu Button: minor code formatting cleanup 2017-02-17 14:39:31 +11:00
doofus-01
d0d5204130 Wooden and White wall terrain variations by doofus-01 2017-02-17 14:36:43 +11:00
Charles Dang
7650eb7dfd Merge pull request #932 from gunchleoc/origin/bug-25469-ngettext
Fixed translation markup in unit::describe_builtin_effect()
2017-02-17 14:11:55 +11:00
Charles Dang
84903c99d2 Drop Down Menu: several improvements to embedded toggle button handling
Any click on a row with a toggle button will now toggle that row's button prior to closing the dialog, unless the
keep_open flag was set, in which case the click will toggle the button but the dialog will not close.

Clicks directly on the toggle buttons themselves are unchanged.
2017-02-17 08:22:07 +11:00
GunChleoc
1af6ed227b Use early return
... for less indentation.
2017-02-16 19:30:52 +00:00
Jyrki Vesterinen
2d809a43d2 Fix bug that prevented dropdown checkboxes from being deselected
This commit fixes the same bug as commit 1e8d8ff7d7171e76df3bd59881c20b68296ba05c that I had to revert.

Thanks to @Vultraz for this fix.
2017-02-16 21:13:33 +02:00
Jyrki Vesterinen
02f78600c1 Revert "Drop down list: stop using has_minimum="false" and remove a workaround"
This reverts commit 1e8d8ff7d7171e76df3bd59881c20b68296ba05c.

@CelticMinstrel and @Vultraz pointed out that the change causes menus
and dropdowns (which are implemented as dropdowns) to initially have
an item selected, which isn't desired.
2017-02-16 20:46:48 +02:00
Charles Dang
f70f1b37e4 Avoid surface copying when rendering text
This was a small proposed change as part of PR #844. While that PR is rather outdated at this point, this seemed like
a simple, useful change.
2017-02-17 05:39:22 +11:00
Jyrki Vesterinen
1e8d8ff7d7 Drop down list: stop using has_minimum="false" and remove a workaround
Has_minimum="false" caused the following bug:

1. In a dropdown with toggle buttons, select any entry.
2. Close the dropdown and open it again.
3. Deselecting the entry selected in 1 is now impossible.

This commit fixes the bug above and addresses a FIXME.
2017-02-16 20:38:10 +02:00
Charles Dang
5b4482f7a8 Merge pull request #926 from sigurdfdragon/mp_knalgan_cleanup
MP: Change handling of recruitment_pattern to match other factions
2017-02-17 05:18:38 +11:00
Charles Dang
4cbd411742 Campaign Difficulty: always keep entries the same height 2017-02-17 05:13:30 +11:00
Charles Dang
187731cedf Addons Manager: display full info of local, unpublished addons
This works by changing the assumption that any addon with addon_info provided is a remote one. Instead, we
construct a addon_info object locally and consider it along with the rest of the addons.

This also fixes a few crashes when using filters in the manager.
2017-02-15 23:08:49 +11:00
Charles Dang
3a1b6eea2b Made get_addon_pbl_info return its own config object 2017-02-15 20:58:31 +11:00
GunChleoc
f53f0c3ce8 Fixed translation markup in unit::describe_builtin_effect()
Replaced hard-coded word order and N_ for all strings in
unit::describe_builtin_effect() with vgettext/vngettext using
placeholders.
2017-02-15 09:38:45 +00:00
Jyrki Vesterinen
3e68d47d56 Refactor the way to show publishable add-ons in the add-on manager
This fixes two bugs:
* publishable add-ons were shown in the "Install Dependencies" dialog
* the game crashed when the player attempted to filter the list if
  publishable add-ons were present
2017-02-14 20:55:44 +02:00
gfgtdf
e1045f9b46 cleanup turn_over_advantage lua code
- removed ugly hack to convert 'break' into 'continue'
- fixed 'color' global varible leaked
2017-02-14 18:24:54 +01:00
Charles Dang
96c2a1eb6f Campaign Dialog: reposition Deterministic Mode checkbox 2017-02-14 01:11:13 +11:00
Charles Dang
66b590b732 Campaign Dialog: reimplement Mods section as an always-visible dropdown w/ checkboxes 2017-02-14 01:08:00 +11:00