71558 Commits

Author SHA1 Message Date
Hironori Fujimoto
db183b331a Use is_composing() instead of raw ime_in_progress_
(cherry-picked from commit 6212a62a985b60110a7350ed28bfb0601cc1d0b8)
2018-10-07 03:18:15 +00:00
Hironori Fujimoto
60f00b4a69 Remove private member 'ime_length_'
In order to get length of composition text, just compare text_ and
text_cached

(cherry-picked from commit 5e22b2b714d58b7f6041c323b0e4c9c7e02bc0b1)
2018-10-07 03:18:15 +00:00
Hironori Fujimoto
adda2d3062 Turn ime_in_progress_ off when composition text is nothing
(cherry-picked from commit 16a8ac7e4956bdf236b518e42913af1ae7360cbf)
2018-10-07 03:18:15 +00:00
Martin Hrubý
cf606d23f3 Drop OS X 10.7 and Growl support (#2749)
(cherry-picked from commit 39d1476ade2a438c783ee0570a51db12da30b33e)
2018-10-07 03:18:15 +00:00
newfrenchy83
4d28725441 Update wesnoth.cbp
(cherry-picked from commit f8abea0de496cdde1da854151a26b570fea06144)
2018-10-07 03:18:14 +00:00
Iris Morelle
b132db1602 Update credits
[ci skip]

(cherry-picked from commit 3c6bb665c6bd6686eeee2711534ee52fcd65ce5a)
2018-10-07 03:18:14 +00:00
Iris Morelle
ca2368edd1 gui2/unit_attack: Fix damage types and ranges being displayed in English
Part of issue #2732.

(cherry-picked from commit 84ce75af191590823033f3186213f1b39375934c)
2018-10-07 03:18:14 +00:00
Iris Morelle
82f728abd0 gui2/unit_attack: Fix alignments being displayed in English
Part of issue #2732.

(cherry-picked from commit 7056ae014ced381cec3e1fdd86a268749bb83562)
2018-10-07 03:18:14 +00:00
Celtic Minstrel
02b6987158 Support to_location in [move_unit]
(cherry-picked from commit 1dd411a84eb6a45c81d14359aaaec7af34351a39)
2018-10-07 03:18:13 +00:00
Charles Dang
435dcbaad9 Updated DejaVu Sans font files to version 2.37 (from 2.35)
[ci skip]

Source: https://dejavu-fonts.github.io/Download.html
I haven't done any codepoint list updates in data/hardwired/fonts.cfg, but that's
not relevant anymore since it's for the legacy TTF rendering system which is in
the process of being removed.

(cherry-picked from commit 11e88dd1caf22af0d65a1785ff8e972f6a99270d)
2018-10-07 03:18:13 +00:00
Celtic Minstrel
aeb48e82b8 Update changelog
(cherry-picked from commit 7a1ea36d3943050bd26072ed8d1cabb7aca2f6eb)
2018-10-07 03:18:13 +00:00
Celtic Minstrel
d2a465a126 Support formula= in [variable] ConditionalWML
(cherry-picked from commit 4e52d62963b10c26f33bccfcbad758c0072da393)
2018-10-07 03:18:12 +00:00
Charles Dang
66ad656805 Updated Oldania font files to version 1.007 (FFEdit)
[ci skip]

Source: http://arkandis.tuxfamily.org/adffonts.html. Previous version was 1.006 (FFEdit).
Also includes the italic and bold variants we didn't have before.

Thanks to @sevu for finding this updated version. :)

(cherry-picked from commit cef0edb4ac02e9cbb3c7044466f9655a1e66278f)
2018-10-07 03:18:12 +00:00
pentarctagon
0c0df08e62 Explicitly set osx_image for osx+scons job.
This is the current default, and even though the job uses scons this also sets the osx version to use.  Therefore it's better to set it explicitly in case the default changes at some point.

(cherry-picked from commit 376f2e9dbe562c21671f88e8f3ef932b003a7fb5)
2018-10-07 03:18:12 +00:00
Charles Dang
9a8462eff7 EI: fixed another Lua syntax error from 3783693cbe95
[ci skip]

I misread the intent of that line in the original. It was supposed to clear the
var, not set it.

(cherry-picked from commit bad574f7c8f6106e6879c14318f3fcf0ec4cc2bf)
2018-10-07 03:18:12 +00:00
Charles Dang
09ebf302e0 Fixed infinite loading screen when logging in with an invalid nickname
Fixes #2728.

(cherry-picked from commit e4b7820ab094fa3847bd8b47fdaca376b4c5ad2b)
2018-10-07 03:18:12 +00:00
gfgtdf
48fee80ac6 remove a [on_redo]
since it was removed in 10561d3e539e6c92aa99d164bbe5bb106c7f35fd this will cause errors. Please make sure it is not used in mainline before you remove something.

(cherry-picked from commit 83007d4825c0a9daca158ec821da34c8968b7536)
2018-10-07 03:18:11 +00:00
gfgtdf
1e0c357612 show the oos savegame dialog when receiving a debug command in mp
with a different text of course.

fixes #2683

(cherry-picked from commit 7621af926b1bd1343c48be8c6dd821b3f1778c26)
2018-10-07 03:18:11 +00:00
gfgtdf
0b6e87742f fix initial selection of mods in sp
(cherry-picked from commit da2081de7713b1c19b2be268e8dd0a48e898bf1c)
2018-10-07 03:18:11 +00:00
Charles Dang
2220078c65 Add ability to bypass strict no-disabled-events assertion when writing events
This is since the Gamestate Inspector can be invoked mid-event (using [inspect])
and it makes use of write_events().

(cherry-picked from commit afaa75842c8914406bed75d3557ec241b0de9b6a)
2018-10-07 03:18:11 +00:00
Celtic Minstrel
d422f2172c Fixup last commit
(cherry-picked from commit cf385537c234f00e34dc9892b0acd6ecf302aea5)
2018-10-07 03:18:10 +00:00
Celtic Minstrel
e92c97c18b Don't bother trying to standardize event name if there isn't one
(cherry-picked from commit f7cc1842bb630bd8c642ea025124ddbfa1c57433)
2018-10-07 03:18:10 +00:00
Celtic Minstrel
6aaf275a4e Don't show a message for missing name in [event] if it has an id
(cherry-picked from commit e317f346e8d9c4363075532efb762cc42646d42f)
2018-10-07 03:18:10 +00:00
Sofartin
751a697093 Add new unit_tests dependencies
(cherry-picked from commit 00e9f4482feecc21ffa88f1a0f8e24f6160f007c)
2018-10-07 03:18:10 +00:00
newfrenchy83
7a80094724 Update wesnothd.cbp
(cherry-picked from commit 67f2ba9767e659d9e6589b1279d8eb5e6c5fd2af)
2018-10-07 03:18:09 +00:00
Sofartin
d0c76505b9 Fixed Xcode Project after 5ece7ac5b71032ec2c6f9bccb57be9a0a863c5ba
(cherry-picked from commit 29b12782a82be70965faf38bfffa2aeacc1ac0ac)
2018-10-07 03:18:09 +00:00
Jyrki Vesterinen
ca150a9129 Visual Studio: increased warning level to /W4 even for release builds
In particular, this enables C4100, the warning for unreferenced function
parameters.

I also fixed some /W4 warnings.

(cherry-picked from commit d4c9db9e3529434bf29a4ed237bc64e67f868f45)
2018-10-07 03:18:09 +00:00
Iris Morelle
d0c9a02189 Revert "Revert "Bump min Boost version to 1.56.0""
This reverts commit cdf9b465c668648721c4638ce117da130ad36284.

May this noise be my vengeance.

(cherry-picked from commit f6a128579ad6d94cc7c8a57bebd1fc2bb0f735a0)
2018-10-07 03:18:08 +00:00
Iris Morelle
777eb9ef2d Revert "Bump min Boost version to 1.56.0"
This reverts commit c82c1ff9059aa19adda6a527f41595a18b8c0a1f.

(cherry-picked from commit cdf9b465c668648721c4638ce117da130ad36284)
2018-10-07 03:18:08 +00:00
Iris Morelle
660aacb10a Use the correct textdomain for the random faction mirror options
Fixes up commit 2e502334f23447609e2553cbbbae8b251f9796bc.

See issue #2709.

(cherry-picked from commit 5c59fade0f96d75e306d48cf3a2448602ae29c7c)
2018-10-07 03:18:08 +00:00
pentarctagon
5e386ef43b Make UTF8 checks fail the build if they find anything.
Also fixes a comment typo in docker_run.sh.

(cherry-picked from commit c456d4b288ca6df59cca3663c10131f2c75e8574)
2018-10-07 03:18:08 +00:00
pentarctagon
14089528e7 Removes a couple scripts that are not used.
utils/travis/install_deps.sh - no longer executes anything outside of the osx if block.
utils/travis/exit_wrapper.sh - I honestly don't know why this exists.
utils/travis/test_wrapper.sh - No longer used as of 7ca5a0df6449b4b895842566d33a38872f1f507e.

(cherry-picked from commit 344b5c56b90cffcbc9638bcb7535bb3e0f073da7)
2018-10-07 03:18:07 +00:00
pentarctagon
55ec77b7c4 Add the updated Dunefolk race description.
See: https://forums.wesnoth.org/viewtopic.php?f=32&t=47721&start=375#p624668
[ci skip]

(cherry-picked from commit 3b5cbc3e3c5e7529412ba38e64145b9303474da3)
2018-10-07 03:18:07 +00:00
pentarctagon
0c69e40d52 Remove deprecated Khalifate references.
(cherry-picked from commit 994e6efa796681e0952d4aeb623adcf3cf75d1ef)
2018-10-07 03:18:07 +00:00
Charles Dang
5a017b5ef1 0 -> nullptr in 2 places
(cherry-picked from commit 3be39a98fe753123ae4685d124876e7a7eb93160)
2018-10-07 03:18:07 +00:00
Nils Kneuper
aa1c926065 updated Spanish translation
(cherry-picked from commit 0bab3fb4d385a326c79bc1f0a27afe399a481d37)
2018-10-07 03:18:06 +00:00
Charles Dang
a386e1a6a3 Cleaned up unnecessary instances of emplace_back(config {})
No need to invoke the copy ctor.

(cherry-picked from commit c2fd4f48f912c48e71382c61e4012ec7fae2f930)
2018-10-07 03:18:06 +00:00
Charles Dang
c41d0ff7bf MP Create Game: attempt to fix RFM type labels being untranslated (#2709)
Since these are defined in their MAKE_ENUM enum with N_, we need to manually un-not-translate
them here.

(cherry-picked from commit 2e502334f23447609e2553cbbbae8b251f9796bc)
2018-10-07 03:18:06 +00:00
pentarctagon
2e76d2fe40 Remove debugging symbols from Travis xcode build.
This removes the -g option from the xcode travis build, since debugging information isn't needed and the increased size was causing the cache to timeout when compressing and uploading it.  ccache max cache size is also decreased from 2 GBs to 200 MBs, which matches the linux+cmake builds.  Fixes #2670.

(cherry-picked from commit b801140344c7cbf86980ff54ef963f9ec2122897)
2018-10-07 03:18:06 +00:00
Iris Morelle
ecc0e8a36d Update the changelog
[ci skip]

(cherry-picked from commit 9d76278e71375257d528df91e82a6156b61f5a45)
2018-10-07 03:18:05 +00:00
Iris Morelle
a9fc823845 i18n: Remove no-op translation::init() function
This function only ever had an implementation when building the i18n API
to use libintl instead of Boost.Locale was possible, in which case its
implementation would be a std::setlocale() call specific to POSIX
systems.

I'm not backporting this to 1.14 since it's an inconsequential cosmetic
thing, or so I'd like to think. Last time someone tried to remove a
similarly empty "init" function elsewhere, things went south pretty
quickly.

(cherry-picked from commit 94c5f64cc62452f420a9886eefc75d5e4af121fc)
2018-10-07 03:18:05 +00:00
Iris Morelle
824f8363af i18n: Make VGETTEXT()/VNGETTEXT() always require a GETTEXT_DOMAIN to be defined
This drops a preprocessor conditional branch that is dead code now that
the file pulls gettext.hpp and the GETTEXT_DOMAIN defaults with it.

See also PR #2711.

(cherry-picked from commit a60239116863ea7592d27f2819017b57a34e0ce5)
2018-10-07 03:18:05 +00:00
Iris Morelle
dfc7c41cb6 i18n: Forcefully pull gettext.hpp into formula/string_utils.hpp
There are cases (deprecation.cpp for one) where string_utils.hpp is
included first, which causes the VGETTEXT/VNGETTEXT definition to use
the textdomain-less (a.k.a. forced wesnoth-lib textdomain) overloads of
vgettext() and vngettext(), because GETTEXT_DOMAIN has not yet been
defined by anything. This again results in strings being looked up in
catalogues where xgettext is not adding them.

This is a companion for PR #2711 I should've noticed sooner. Without it,
there were still cases where interpolated strings would not be
translated due to vgettext() using the wrong textdomain for them.

I ran a quick scan on the codebase to make sure there aren't any files
including formula/string_utils.hpp before defining their own
GETTEXT_DOMAIN instead of the gettext.hpp default.

(cherry-picked from commit 5c28dcaab66e34af718c7ceff6ccc9e33b58b039)
2018-10-07 03:18:04 +00:00
Iris Morelle
1ef6c5b2c0 Replace all instances of naked vgettext() calls with VGETTEXT()
The vgettext() function, while declared in src/formula/string_utils.hpp,
actually has its implementation out-of-line in
src/formula/string_utils.cpp where GETTEXT_TEXTDOMAIN is defined to
"wesnoth-lib". Because vgettext() is implemented in terms of the _()
function (an inline wrapper around translation::dsgettext()), it passes
the textdomain defined in the file where it was implemented as a
parameter.

This means that every case of vgettext() being used in other code units
where GETTEXT_TEXTDOMAIN is not defined to "wesnoth-lib", is broken if
the string being looked upon doesn't coincidentally exist in the
wesnoth-lib textdomain.

Ages ago, to work around this limitation, an overload of vgettext() that
takes the textdomain name as a parameter was introduced (see commit
0ba3d05204abff72f7d95cf11a91536dab5aa20a). Since this form of vgettext()
is rather unwieldy to use (and in particular, the xgettext message
extraction tool mistakes the first argument for the msgid, see below), a
VGETTEXT() macro was also added that uses the GETTEXT_TEXTDOMAIN symbol
defined in the file where the call is made, and thus we get the correct
string from the correct textdomain.

Switching all cases of naked vgettext() in mainline to VGETTEXT() fixes
a myriad of situations where an interpolated string that has an extant
translation does not actually get translated in practice because of the
mismatched textdomain reference (see issue #2709 for an example with MP
game titles). I couldn't find any cases of the companion vngettext()
function (which handles plurals) being used in the wild naked, but for
future reference it also has a companion VNGETTEXT() macro to pass the
correct textdomain to its textdomain-parameter overload.

One caveat is that this commit DOES break the string freeze in one
particular case -- src/units/unit.cpp has a case where the
textdomain-parameter version of naked vgettext() was in use with
"wesnoth" as the first parameter, and xgettext misidentified this as a
translation entry for a "wesnoth" string in the file's assigned
textdomain (which is the default textdomain, wesnoth). So this will
result in the next pot-update both removing the spurious "wesnoth"
string AND adding the correct string to the relevant catalogue template
("<span color=\"$color\">$number_or_percent</span> HP").
to that textdomain.

Other than that, I believe this does not break the string freeze in any
other fashion and it shouldn't result in any regressions for i18n.

It might be worth considering in the future renaming vgettext() and
vngettext() to names that make people less likely to misidentify them as
functions they can freely call directly without regard to the textdomain
assignment issue.

(cherry-picked from commit c5b3947e4a837dc98868e3b2c3fa55668fec27a4)
2018-10-07 03:18:04 +00:00
Charles Dang
6f1263d34d Used UNUSED macro instead of (void) where applicable
(cherry-picked from commit 7a9ed8d3631cecc7053ed91b2501d6d145d7a4cd)
2018-10-07 03:18:04 +00:00
Charles Dang
3fce0c3816 Used stdlib math functions instead of global C versions
(cherry-picked from commit 410398a70b37d6cf4a75ff1e3abd43225413c9d2)
2018-10-07 03:18:04 +00:00
Charles Dang
d5227d8fab Added two missing textdomain headers
[ci skip]

Should fix two of the issues mentioned in 2709.

(cherry-picked from commit 8d1ec6216bb336f29f5e213df5b1418703cdc0a0)
2018-10-07 03:18:03 +00:00
Lari Nieminen
fa1e37d71d EI: Fix Lua syntax error from 3783693cbe95
[ci skip]

(cherry-picked from commit 4d86af796ca46f204f958b712465a05bdfa0de75)
2018-10-07 03:18:03 +00:00
ln-zookeeper
733d8ff979 EI S03: Changed Mal-Kallat back to male
He was changed to female in f4d67031a436 even though he's addressed as "brother" in dialogue. Reported on the forums.

(cherry-picked from commit 3be2ff518781c7a7104e810707be64567cc26e27)
2018-10-07 03:18:03 +00:00
Sofartin
ccf6998d2b Fixed Xcode Project
(cherry-picked from commit 00dac71a9036c2bc897bb4adf3ea510dfe37ee12)
2018-10-07 03:18:03 +00:00