75416 Commits

Author SHA1 Message Date
Charles Dang
dd02bdecc8 Fixup 167f4a1a1e55c 2019-10-19 19:12:08 +11:00
Charles Dang
7cedcb57ab Mouse Events: removed an override that only called the base method 2019-10-19 18:44:08 +11:00
Charles Dang
773cc212b3 Animated: simplified template stuff
Just... why was T_void_value a thing.
2019-10-19 18:44:07 +11:00
Charles Dang
4a5d34d1be GUI2/Grid: made use of std::exchange 2019-10-19 18:44:06 +11:00
Charles Dang
c15cb0696e GUI2: added display and execute wrappers for a bunch more dialogs
Made use of them where applicable. There are a whole bunch of cases where the dialog
object only exists to check its return value, but I'll update those separately.
2019-10-19 18:44:05 +11:00
Charles Dang
8587a14cde Removed preference to disable halos
There's really no reason to have this anymore. It was (AFAIK) introduced years ago
as a performance-saving measure, then was moved to Advanced Preferences in 1.13 since
modern PCs mostly have no issues.
2019-10-19 18:44:04 +11:00
Charles Dang
de8077add6 Sneaky C-style arrays be hiding
Also dropped some unused code in unit_type.

And there's still one in language.cpp, but I'm not entirely sure if it's safe to
drop the last empty entry there so I left it.
2019-10-19 18:25:33 +11:00
Charles Dang
3c01a4350b Plugins/Context: removed C-style array ctor and use
This likely existed because this code was added in 2014 before we switched to C++11
and initializer lists.
2019-10-19 18:25:17 +11:00
Charles Dang
ab0197343e Convert a bunch of C-style arrays to std::array 2019-10-19 18:24:54 +11:00
Charles Dang
619ceabb9d Lobby Data: removed unused era_short field 2019-10-19 18:22:11 +11:00
Charles Dang
e643d2dce7 Removed joystick code
This was never fully implemented and has been essentially abandoned. If we want to
add this again, we should look to adding full game controller support (Steam controller,
for example), though I don't know how suited this game is for controller support. As for
as I can tell, the only working part was ever map scrolling.

Includes a sqrt -> std::sqrt conversion I forgot in this file awhile back.
2019-10-19 18:21:14 +11:00
Charles Dang
9a7b11f08f IPFs: simplify ~TC() implementation
This results in the same behavior as before (default color outside a scenario, side's
chosen color during one) and is more consistent with other places in the code. They
both end up accessing `game_config::team_rgb_range` anyway, this is just in a slightly
more roundabout way.
2019-10-19 18:18:22 +11:00
Charles Dang
9967dde327 Cleaned up a few unnecessary AI-related includes outside ai/ 2019-10-19 18:17:43 +11:00
Charles Dang
167f4a1a1e GUI2: dropped a remaining t-prefix from a type 2019-10-19 18:15:57 +11:00
Charles Dang
b0d18afd2f GUI2: praise auto 2019-10-19 18:13:59 +11:00
Charles Dang
97acce2064 Removed deprecated objective text macros
[ci skip]

These are incorporated into the objectives dialog automatically. They lack a deprecation
notice, but they should be given level 3 status on the 1.14 branch.
2019-10-19 18:12:21 +11:00
Charles Dang
871e857771 Begone, MENU_IMG_TXT!
[ci skip]

This utilized the deprecated DescriptionWML syntax.
2019-10-19 18:06:02 +11:00
Charles Dang
92c7d2fed0 Removed deprecated put_unit arg orders
x, y, unit and plain unit
2019-10-19 18:04:11 +11:00
Charles Dang
a766d2d93a Removed a bunch of things deprecated at level 3
* [combo] in [modification]s
* Support for legacy DescriptionWML in the MP Faction Select dialog
2019-10-19 18:03:28 +11:00
Charles Dang
021339bcc5 Removed macros deprecated at level 2 and 3
[ci skip]
2019-10-19 18:01:33 +11:00
Charles Dang
2adac53461 GUI2/Tree View: use NOTIFY_MODIFIED events instead of manual callbacks
Unlike other widgets where `this` is the event target, the tree nodes fire the event
with the tree widget itself as the target.

I had added a fire-event call in f97dc8ae12be1b8982ab87b748266f915a84e15d, but with
the target as the node. I don't think there was any way that would have worked...
changed.
2019-10-19 17:52:14 +11:00
Charles Dang
e8fb922516 GUI2/Tree View [Node]: formatting cleanup 2019-10-19 17:52:12 +11:00
Charles Dang
c1774005a9 GUI2/Tree View Node: used std::make_shared when possible
Child nodes were still managed with unique_ptrs in 1.14, so we couldn't use make_unique
there. Child nodes are now managed with shared_ptrs here on master.
2019-10-19 17:52:11 +11:00
nemaara
36b4b24a8f DiD S5: increase player castle size 2019-10-19 02:11:17 -04:00
nemaara
86fbd9c724 DiD S5: rename scenario 2019-10-19 01:30:12 -04:00
nemaara
0eaaa1f990 DiD S4: rename scenario 2019-10-19 01:30:00 -04:00
josteph
7f96d1f288 units: Add custom [special_note]s. 2019-10-19 02:56:43 +00:00
Celtic Minstrel
f8c7455928
Fix schema rejecting top-level color range/palette tags (#4487) 2019-10-18 22:18:17 -04:00
nemaara
5800acd8ea
Merge pull request #4476 from newfrenchy83/newfrenchy83_replace_deprecated_special
Upgrade special=* uses in master
2019-10-18 21:46:17 -04:00
Charles Dang
0e85ea8619 Disable labeler for now since it doesn't work with PRs opened from forks
See https://github.com/actions/labeler/issues/12#issuecomment-525762657 for more info.
2019-10-19 11:46:24 +11:00
mattsc
ba3c26bafd Update changelog with Experimental AI changes 2019-10-18 17:42:05 -07:00
nemaara
fc45f304ea Add DiD update to changelog 2019-10-18 20:22:18 -04:00
nemaara
34ef2281b2 DiD: set colors for each faction 2019-10-18 20:20:18 -04:00
Charles Dang
49f4656c08 Don't write needs_select to menu item config unless true 2019-10-19 10:15:13 +11:00
Steve Cotton
14284e88c3 Editor help: remove whitespace from ends of strings
Note: this does not include a fix for #4484, that a double-quote in a _<< >>
delimited string causes a broken msgid. Wondering whether to remove that from
this text, but would prefer to add the feature to wmlxgettext.

Follows the comments in #4480, about how to handle whitespace at the beginning
and end of translatable strings.

This is text that was added after the last pot-update, so updating it
again now will hopefully be before the translators start on it. Some
text that was split into paragraphs is now combined in to one block,
other parts are still split but with non-translatable whitespace; the splits
will hopefully separate the scenario editor parts which are going to change
again before 1.16.0.

The wmlindent override is because the logic for multiline strings isn't working
for << >> delimited strings.
2019-10-18 10:22:58 +02:00
Charles Dang
baec45fc53 Fixed turn display at ridiculously tiny res
[ci skip]
2019-10-18 15:30:21 +11:00
Charles Dang
cb35e6885f Ensure enough space to display turn numbers in the hundreds
[ci skip]
2019-10-18 15:30:18 +11:00
josteph
20df39ddc3 Add #2907 to changelog 2019-10-18 02:50:24 +00:00
Iris Morelle
36d834a564 Fix missing whitespace in log message 2019-10-17 23:49:05 -03:00
josteph
9e7988aa11 Help: Show abilities and ability upgrades separately
Fixes #2907
2019-10-18 02:48:22 +00:00
josteph
bac76864cf Add two recent commits to changelog 2019-10-18 02:06:33 +00:00
josteph
f973919fdc sidebar: Show number of attacks left when a unit has max_attacks > 1. (#2667) 2019-10-18 02:01:10 +00:00
josteph
e285a2c530 Silver Mage: Convert special note to new syntax
See #4480 for the leading space.
2019-10-18 00:30:27 +00:00
josteph
c8a993f6d9 Damage Calculations: Consistently use "resistance" and "vulnerability" for >100% and <100%
Fixes #2002
2019-10-17 23:39:29 +00:00
mattsc
bdf5421fd5
Merge pull request #4437 from mattsc/expai_recuit_higher_levels
Experimental AI: make AI recruit higher level units
2019-10-17 07:09:53 -07:00
josteph
ce4901e92c saves: Add a po comment to the string "replay". 2019-10-17 03:23:51 +00:00
newfrenchy83
409b5360b1
replace deprecated special 2019-10-16 18:00:20 +02:00
newfrenchy83
d9481207d5
replace deprecated special= in master 2019-10-16 17:55:20 +02:00
Steve Cotton
384079a16a Contributing.md: Mention UTF-8 and remove the Tolken references 2019-10-16 12:44:23 +02:00
Wedge009
027404491b Display translated string for "random" in MP staging
Resolves #2954
2019-10-16 18:38:00 +11:00