26644 Commits

Author SHA1 Message Date
Steve Cotton
de92d17a6d WIP: Test [move_unit] moving back to the starting hex 2019-12-14 11:31:55 -05:00
Celtic Minstrel
3303be6c91 Restore the dir+count test for move_unit and add the syntax to the schema 2019-12-14 11:28:37 -05:00
jostephd
bb583c8e98
Merge pull request #4612 from jostephd/lua-deprecate_api-__index-__newindex-simplify
lua: Simplify the __index and __newindex wrappers in wesnoth.deprecate_api
2019-12-14 14:15:09 +00:00
josteph
1df045fba0 fixup! lua: Simplify the __index and __newindex wrappers in wesnoth.deprecate_api 2019-12-14 14:14:12 +00:00
Steve Cotton
b479d6f7ac Remove tests of move_unit's count and move-unit-to-its-own-hex functionality
The count is undocumented on the wiki, and it's causing the schema validation
to fail. The functionality makes sense and I hope it continues to be supported,
but for now let's have a minimal unbreak-the-build change.

Trying to move a unit to the hex occupied by itself causes it to move to a vacant
adjacent hex instead; splitting the move into two separate [move_unit] calls
passes as expected. That sounds reasonable implementation-defined behavior, but
will make a PR to discuss it.
2019-12-12 08:47:53 +01:00
walodar
0cd53c9b8d Fix: incorrect dunefolk image path in multiplayer factions and Dune Apothecary attack animation 2019-12-11 18:45:19 +01:00
sigurdfdragon
06922c2a35 SotA: Update zombie lua dialog to adjust for deprecated lua changes
Removing V = wml.variables and using wml.array_access.get as the only
variables needed from wml is a single variable array.
2019-12-10 23:32:43 -05:00
Celtic Minstrel
b8759f8c19 Add some additional cases to the move_unit test, and fix a few issues that they revealed
One of the cases fails due to something in find_vacant_tile - perhaps someone else can figure out how to fix this?

If nothing else, setting check_passability=no in the [move_unit] should do it, but I'd prefer not to have to do that...
2019-12-10 21:16:06 -05:00
Celtic Minstrel
cbd88814c3 Fix #4622 2019-12-09 22:12:39 -05:00
nemaara
3848f31484 Liberty S5: move some images around 2019-12-09 00:07:16 -05:00
nemaara
82a896f7f2 Liberty S5: prettify map 2019-12-09 00:01:38 -05:00
doofus-01
a55a10c27c
SoF: Revisions to S1-S3t (#4609)
* SoF: some early scenario touch-ups

* SoF: Sc2.5 - inserting new scenario with mine-cart mechanics, as introduction, better use can be in future scenarios

* SoF: some fixes to mine carts

* SoF: add attack events to automatically exit the cart in combat

* SoF: boost base score to overide other standing animations - still need to deal with idle animations

* SoF: Some revisions around third scenario

* SoF S1,S2: adjusting/fixing the elf side

* SoF S1 - adjust Haldric side 2, so AI leader does not jump in the snow if enemies get close

* SoF maps - removing two unused maps (introduced in the PR, not already existing)
2019-12-08 19:33:26 -08:00
nemaara
3d70628d73 Liberty S4: reduce map size 2019-12-08 04:48:26 -05:00
nemaara
99708e0808 Liberty S3: small touchups 2019-12-08 03:54:41 -05:00
nemaara
632fb133de Liberty S2: beautify map 2019-12-07 17:42:15 -05:00
Celtic Minstrel
c366998021 Fix an issue with items and location sets
Fixes #4621
2019-12-07 17:21:03 -05:00
Celtic Minstrel
e009989ec3 Fix some places that were erroneously calling string.format instead of stringx.vformat after 30240aa7cda41bd5c1a660f17c67e76a9b9ab2cd
Fixes #4621
2019-12-07 17:21:03 -05:00
Celtic Minstrel
ee40ca2146 Lua uses nil, not null. Oops! 2019-12-07 17:21:03 -05:00
nemaara
a7107f26ab Liberty S1: small touchups 2019-12-07 15:54:39 -05:00
Celtic Minstrel
d66e957e1d Fix ilua's strict mode 2019-12-07 14:48:55 -05:00
Celtic Minstrel
29e11e7914 Lua functional library: make reduce accept an operator name in place of a function, add zip 2019-12-07 13:52:49 -05:00
Steve Cotton
4e92cc46ad Fix move_unit's parsing of to_x and to_y (fixes the unit-test timeout)
Also extend the unit test to at least check the end result of comma-separated
values, as there was previously nothing testing the effect of providing more
than one value.
2019-12-07 18:41:32 +01:00
nemaara
0b89c6e4c9 DiD: decrease difficulty ratings 2019-12-06 22:10:39 -05:00
nemaara
9fbaee3be7 TSG and AToTB: change to novice level 2019-12-06 22:08:18 -05:00
nemaara
611010f634 Swap campaign ranks of Liberty and HttT 2019-12-06 21:49:20 -05:00
nemaara
447f572d90 Liberty: dialogue tweaks 2019-12-06 21:48:21 -05:00
sigurdfdragon
fccd30baf4 SotA: Fix special plauge attack making rats when spiders are called for 2019-12-06 20:44:23 -05:00
sigurdfdragon
3d38f7b6e2 SotA S05: Remove unneeded code and fix bug of regular WC in recruit list 2019-12-06 20:44:23 -05:00
sigurdfdragon
c6d7c94bfb SotA: Fix last breath dialog for bats firing multiple times in the campaign 2019-12-06 20:43:39 -05:00
nemaara
2a24cf0c79 DiD: remove end year 2019-12-06 04:54:36 -05:00
Celtic Minstrel
0b433d7ca1 Implement a Lua strict mode which eliminates all deprecated things
Note: At present the only way to enable this is by editing the core.lua file to add the line "wesnoth.strict = true".
2019-12-04 21:52:47 -05:00
Celtic Minstrel
9ae3be7386 Add stringx functions for parsing ranges 2019-12-04 08:55:17 -05:00
Celtic Minstrel
7a1390adf7 Remove "wml-utils" require from files that no longer use it 2019-12-04 08:48:53 -05:00
Celtic Minstrel
f2f35cbd38 Fix broken [move_units]dir= 2019-12-04 08:46:22 -05:00
Celtic Minstrel
d9b5e3c4df Replace uses of wml_utils.split with stringx.split 2019-12-04 08:46:04 -05:00
Celtic Minstrel
31467d29d7 Deprecate wml_utils.split in favour of stringx.split 2019-12-04 08:09:51 -05:00
Celtic Minstrel
34cce96a58 Deprecate wml_utils.parenthetical_split in favour of stringx.split
There were no uses of this function in core Lua files.
2019-12-04 08:07:15 -05:00
Severin Glöckner
b32a08a6e7 HttT: change usage type of Queen
[ci skip]
2019-12-04 10:47:22 +01:00
Severin Glöckner
66d7132d01 TSG 8b: add comment and remove old code
[ci skip]
2019-12-04 10:45:31 +01:00
Celtic Minstrel
4eb043bb16 Deprecate wml_utils.trim in favour of stringx.trim and update all use cases 2019-12-04 00:53:59 -05:00
Celtic Minstrel
e81a0377b0 Update uses of moved format functions 2019-12-04 00:50:00 -05:00
Celtic Minstrel
533206674a Deprecate wesnoth.wml_matches_filter 2019-12-04 00:47:29 -05:00
Celtic Minstrel
7ee7d6d47c Lua: More stuff for the stringx module
- Move format_conjunct_list and format_disjunct_list
- Move wesnoth.format (renamed to vformat so as not to conflict with string.format); it's also available as tstr:format()
- Add stringx.trim
- The convenience wrappers of stringx.split now set the remove_empty and strip_space flags
2019-12-04 00:45:36 -05:00
Celtic Minstrel
027be31826 Add wml.interpolate function for vconfig interpolation from a source other than the game variables
Unlike wml.tovconfig, this method works even in the plugin and map generation contexts.
2019-12-02 22:45:06 -05:00
Celtic Minstrel
11a57e0fa7 Move helper.find_attack -> wesnoth.units.find_attack 2019-12-02 22:39:34 -05:00
Celtic Minstrel
d5c1c9734f Fix the deprecated helper.set_wml_tag_metatable using a non-existent core table 2019-12-02 22:39:34 -05:00
Elvish_Hunter
ec41359368 wmlscope: detect and analyze optional macro arguments 2019-12-02 21:23:58 +01:00
Earth-Cake
1e19cd5d23 Bug fix
Fix a bug regarding enemy leader leaving starting position and going with his soldiers.
2019-12-02 07:19:09 -06:00
Celtic Minstrel
732b7942bb Replace all references to deprecated functions in the helper module
(and remove the require if this meant it was no longer used)
2019-12-02 01:10:34 -05:00
Celtic Minstrel
74e004c265 Use a location set in the implementation of the item functions and WML tags 2019-12-01 22:30:31 -05:00