The motivation for this is that Xcode is (for some reason) incapable of automatically reloading a scheme that has changed on disk, and overwrites it the moment you try to edit it with whatever it has in memory.
With this change, the information lost when it does that will be much less; in many cases, just a checkbox to toggle back on.
It is not used, and appears to have been unused for a long time.
It was related to mouseover hex brightening, but the brightening
amount is hardcoded. There were associated hex_semi_brightening,
mouseover_image and selected_image keys, but that info is also
hardcoded, and those keys appear to have been removed already.
This seems to have been applied to 1.14, but not 1.15/master at the time.
-
Revert network_transmission.cpp/hpp to its 1.14.7 version
I re-ran the timing test discussed in PR wesnoth#4201 (comment linked to below), and
saw similar numbers. The old, simpler code downloads an 86.1MB addon in 25
seconds, the code with the extra thread takes 29 seconds.
https://github.com/wesnoth/wesnoth/pull/4201#issuecomment-517856090
sdl_copy_portion (only used one place internally, so inlined there)
stretch_surface_horizontal (obsoleted by hardware rendering)
stretch_surface_vertical (obsoleted by hardware rendering)
tile_surface (obsoleted by hardware rendering)
surface_submerge_alpha (now done via IPF)
blit_surface (not used anywhere, so sdl_blit must be fine)
Functions have moved to draw.hpp and sdl/texture.hpp as appropriate.
Most of these had already moved. set_texture_blend_mode() was the last
uncategorized function. It is now in texture.hpp.
These were added in 8f945cf235faa4c5cbfe955f3ddf42b6a48d5d4d, but since the "new" listbox
implementation never came to be, these have just been unused clutter. There was one place
they were used as parameters in a manual call to calculate_blitting_rectangle, but that was
refactored out in db1717721ed4c8a8e8e7315fed740787704e695f.
This also removes an overload of widget::draw_debug_border, since without the offsets, both
functions now did the same thing.
This affects:
* widget::draw_background
* widget::draw_children
* widget::draw_foreground
* widget::impl_draw_background (offset overload removed)
* widget::impl_draw_children
* widget::impl_draw_foreground
* widget::calculate_blitting_rectangle
* widget::calculate_clipping_rectangle
* widget::draw_debug_border
Viewports now manage the clipping rectangle when set and unset,
converting it to the viewport coordinate space. Some improvements
were also made to handling when clipping is disabled.
