It allows to use a viewport in a grid. It's now also possible to own the
widget in the viewport.
The code is used to experiment with a different approach of the
implementation of a listbox.
It seems I forgot to take care of the sorter instance when rearranging
columns in 2012-05-21T03:56:39Z!shadowm@wesnoth.org. As a result, some columns were sorted by inadequate
criteria (e.g. Type by numeric comparison).
When there's only one button with this hint, and there's a textbox, try
to align the button to the textbox. This makes the Filter/View Mode row
in the Add-ons Manager dialog look tidier.
This allows placing a button at the top-right corner in a stock gui1
dialog.
This implementation might not be bug-free (has only been tested against
the Add-ons Manager dialog for now), but it works and doesn't introduce
or fix bugs in other current dialogs.
...together in regular view modes
This is done by making the Version text for applicable entries two lines
long. The first line contains the local version; the seocnd line, the
remote version. The text is also highlighted in the same color as the
status line.
With translations, running out of space due to the Type column and the
status line (which expands the Title column) is an inevitability. Thus
we need another compromise.
Type has to go last since it can be the longest due to the non-obvious
acronym usage (e.g. "MP scenario"). A later commit will introduce more
advanced filtering to make up for it when it goes missing due to space
constraints.
It should be noted that this is mostly relevant only for horizontal
resolutions < 1024.
The old column order:
AM: Icon Name Version Author Type Downloads Size
DP: Icon Name Version Author Type Size
UA: Icon Name OldVersion NewVersion Author Size
The new order:
AM: Icon Name Version Author Size Downloads Type
DP: Icon Name Version Author Size Type
UA: Icon Name OldVersion NewVersion Author Size
(AM being the Add-ons Manager; DP, the Dependency Prompt; and UA, the
Upgradable Add-ons view.)
The most important difference is that Size goes always before Downloads
and after Author now since people with low resolution displays are very
likely using services with poor/restricted Internet traffic; making sure
they can see the Size without reading the Description dialog seems only
logical.
An upcoming commit with make the gui2::taddon_description dialog display
all of the information just in case.
If an action could not be undone, it makes no sense to "redo" it, and
vice-versa.
(In particular, certain movement undos produce a message stating
"Possible abuse of [allow_undo]" without crashing, but then redoing
that move caused an assertion failure before this change.)
Until now there was only a single, verbose prompt for the .pbl case.
Since people may use a VCS to contribute to an add-on without having a
.pbl file, that case is also now covered by this commit.
There's a single prompt with a list of sensible content that might be
"permanently lost" on installation. The list may contain VCS or .pbl
files for now, but perhaps at some point in the future someone might
want to make it into a full list of extra files or something.
...and elaborate on their state in gui2::taddon_description instead
This means they get both the "Installed" (or "Published") line, and the
green highlight. gui2::taddon_description displays their detailed status
as "not tracking local version". This approach seems sensible since we
have limited space for the status line in the GUI1 Add-ons Manager
dialog.
As a side effect there's a hypothetical "Unknown" status line that's
only there to keep gcc 4.7 happy.
- add new files
- remove HAS_ITERATOR_DEBUGGING=0 define, since the functionality is
too useful and it should be _HAS_ITERATOR_DEBUGGING with a leading _
This happens rather often in valid code as well, so make it debug
messages. But at least in debug mode it's possible to get more
information regarding the missing child.
