(1) LuaAI ai.get_avoid() now provides the correct coordinates (not
offset by -1), this reduced some code duplication and code
inconsistency (2) Tweaked ai.attack() of LuaAI to consider weapons are
numbered from 1 and so forth, so that this function is more consistent
to the Lua indexing style
The rewrite only has minor visual differences, ImageMagick's
`composite -compose difference'
shows no visual differences.
The change makes it possible to optimise the code on the ARM Cortex A8
using NEON instructions.
Fix a variable leak, a misplaced key and add a fallback
to the existing type in case we cannot find a suitable type to
turn into + a beg to report this. Theoretically we can also
have level 3 units on the enemy side here which aren't taken care
of.
Turns out that while the cause of the bug is easy,
it was obscured by the AI recruitment which did apparently change
and revealed the bug; and by the AI which does of course not
always make the same decisions what made the problem appear
at random.
there are some issues preventing the plank bridge from being used
adjacent to walkable areas but it is still useful enough to be worth
adding and it is likely that either the artist or I can resolve these
problems
This test is added to test modifications of the algorithm. It also adds a
programme to create the test images. And the test images to test whether
the output of the algorithm remains the same after changing the algorithm.
loonycyborg can you add this new programme to scons.
...with an upscaled version of the correct size (125x39), provided in
bug #19415
This solution seems sensible for reasons stated in the bug report. I
normally dislike upscaling graphics, but in this case the original is
crappy enough (it even appears to have JPEG artifacts?) and the
difference barely noticeable to the human eye.
Since this kind of changes can apparently break add-ons nowadays, this
probably should _not_ be backported to 1.10.
Remaining items to do with this:
* Add a quick explanation about uninstalling add-ons
* Review for style/content/helpfulness
* Implement a Help button in the manager (this somehow breaks
spectacularly atm, hence not committed)
