Remove some unnecessary includes of wml_exception.hpp.
The last callers of these functions were removed in f545fbcbe8 and 4437691bdd,
and any potential future callers can use config::get_old_attribute instead.
Removes some translatable strings.
Remove some dead GUI1 code, leaving the editor's palettes as the only
code that calls font::set_help_string. This function shows a tooltip-like
text at the bottom of the editor's screen, for example when the paint tool
is active it shows which terrains are assigned to the left and right mouse
buttons.
There is similar functionality in GUI2, for example when hovering over the
title screen's buttons, which is handled via event::MESSAGE_SHOW_TOOLTIP.
This cleanup is the groundwork for moving the label in the map editor so that
it doesn't always obscure the southmost hexes of the map. The implementation of
font::set_help_string() has moved during 1.17's refactoring (from CVideo
in 1.16 to floating_label in 1.17.12); the intention is to replace it with
editor-specific code in a later PR.
Checking that the code is dead
---
Nothing called widget::set_help_string, therefore the rest of the removed code
in the widget class was effectively dead.
For the menu class, nothing set item::help. I doubt it was ever used; it was
added in a commit titled "changes to wose stats" that presumably accidentally
captured some work-in-progess C++ changes too: e2597cbc83.
The menu class is now only used by the help browser. The complete set of .cpp
files that get recompiled after changing menu.hpp are:
* help/help.cpp
* help/help_browser.cpp
* help/help_menu.cpp
* video.cpp
* widgets/menu.cpp
* widgets/menu_style.cpp
Since a0ee38a49, the inner this_item was still in scope when the inner loop
writes changed data back to the outer loop's variable, which meant that
changes were silently ignored.
A lot of the changes in wml-flow.lua are just indentation because of the
extra block.
Ensures that files either use tabs for indentation or spaces for indentation,
but don't switch between the two within the same file.
This doesn't fix the whitespace, it's a simple check to flag it up
on the assumption that it's better to use an editor or code formatter
to clean up the file.
Elsewhere in the CI we use the luacheck tool - while that can detect
mixing tabs and spaces in a single line's indent, it doesn't check for
inconsistent indentation within a file.
Instead of being either complete or incomplete, achievements can now specify a value at which they will be considered complete. For such achievements that are not yet complete, a progress bar is added to the achievements dialog showing how close to completion the achievement is.
The Windows CI builds are intermittently failing. Even though a prebuilt vcpkg
is already cached, it will sometimes choose to rebuild lots of packages anyway.
On some of those rebuilds, there's a failure when building glib.
On the times that it does fail, the failure is often enough glib that checking
the build log manually seems more reasonable than checking what failed.
An alternative would be to look at why it sometimes chooses to rebuild, but
that would mean remotely debugging a CMake config. I'm hoping the build log
will have a clear compiler error pointing to a race condition in the order that
packages are built.
in addition to simplify the calling of calculation function for int weapon specials, it also because an commit what i want push in a PR requre this function.
These keys are supported in game_config.cfg, but currently they're not used in
that file, instead falling back to the defaults in the C++.
The name show_partly_orb is inconsistent - in other places, including the WML
that's stored in the user's preferences file, it's called show_partial_orb.
These are leftovers from the original implementation of the disengage orb,
when it was a new color for the single-color orb. During the review process it
became the two-color design, but these parts were left in.
The value of orb_status_helper::get_orb_color(orb_status::disengaged) is used
(both before and after this commit) by the minimap; this commit changes
get_orb_color to return the partial_color() directly. The result will be the
same as before, because disengage_color() returned the same as partial_color().
Prior to this commit that was done by giving both orbs the same value in
game_config.cfg. If the advanced preference to change orbs colors was used, the
value chosen for the partial orb was passed to set_disengage_color() too.
Switch from obsolete Emacs Lisp functions to modern functions in order
to remove two compiler warnings.
Properly quote lambdas with #' to remove two more compiler warnings.
Looking at recent build failures, one of Debug or Release is using the prebuilt
vcpkg from the cache, and the other one is detecting it but then deciding to
rebuild many of the packages.
The build logs circa 8bd8c53f9887ae2440b9a4d29ec55655de08b519 are no longer
accessible, only the success/failure and time taken are still accessible.
Looking at build timings around those changes is inconclusive, however my guess
is that the CI is noticing that CFG is different between the two builds, and
that's forcing a rebuild for one of them.
