mirror of
https://github.com/wesnoth/wesnoth
synced 2025-04-27 22:25:28 +00:00

1. The internal type is a std::string, the lua getters/setters should reflect that like all the existing ones already do instead of making implicit conversions. 2. It doesn't make sense to convert the already translated string into a t_string again upon getting it. 3. The setter in team.cpp you added is redundant. 4. The attribute is apparently not really meant to be modified by lua or wml so a tag is no good idea.