mirror of
https://github.com/wesnoth/wesnoth
synced 2025-05-19 18:22:09 +00:00
7ddf691e13
Partially reverts 6a21fdc6750a8342846ef18248517808316c4118 Fixes #5643 Fixes #7238 There's a bunch of global things that can be accessed either via global pointers in the `resource` namespace, or via `display::get_singleton()`. The singleton and these global pointers are set up in `play_controller::init`, however there's a section where things are available via the global pointers but the `display` singleton doesn't exist yet. During that time, checking whether an ability is active can crash the game. Removing the global pointers is a good goal, but detouring through a GUI class to access the data causes its own problems. The "has already been confirmed valid by both callers" comment is replaced with an assert, because there's currently at least three callers.
This directory is where PR authors can add a file per PR containing the text that should be added to the main changelog.md during the release process for the next version. The format should match that of the main changelog as well as use an existing category defined there. For example, a file could contain:
### Terrain
* Change codes "Irs, Ias, Icr, Ior, and Icn" to "Isr, Isa, Isc, Iwo, and Iwc", respectively
The purpose of this is to make it easier to add changelog entries with a PR while avoiding merge conflicts in the main changelog file if someone ends up merging their PR before yours.
The contents of this directory (aside from this README file) will then be deleted after each release.