mirror of
https://github.com/wesnoth/wesnoth
synced 2025-04-27 21:01:30 +00:00

since the recent changes to overlays= in particular 1a7724e5472, e71033374c35 and b2cd1cf6c [unit]overlays= is no longer the recommended way to add an overlay and the use of the apply_to=overlay effect is reccomended instead, so adding it to the [trait] is the most natural option here. this in particular fixes #4058 . Also people simply forgetting the IS_LOYAL macro was a not-so-uncommon cause of bugs. In some cases people want to give the LOYAL trait without giving the loyal overlays for those cases i added a optional OVERLAY parameter to the {TRAIT_LOYAL} macro, also heroes should now use {TRAIT_LOYAL_HERO} instead which uses the hero overlay. The IS_LOYAL and IS_HERO macros are no longer needed in combination with those traits.