ea25735501
Fixes a crash when playing a replay that includes a theme, when that theme doesn't have all of the buttons that the removed code expected. For example, this replay from SXRPG 5.2.3 has two replay themes, of which one lacks button-nextmove: * https://replays.wesnoth.org/1.14/20190701/SXRPG_TempleOfBones_Turn_8_(53897).bz2 All of the button::enable() calls were unnecessary logic, because the hotkey system will query replay_controller::can_execute_command() and enable or disable the buttons to match. However, the enable() calls appear to have had the side-effect of triggering the hotkey system to check the buttons' required states and redraw. The code in build_replay_theme() was unreachable, because replay_controller doesn't attach itself to the completely_redrawn event.
About
The Battle for Wesnoth is an Open Source, turn-based tactical strategy game with a high fantasy theme, featuring both singleplayer and online/hotseat multiplayer combat. Fight a desperate battle to reclaim the throne of Wesnoth, or take hand in any number of other adventures.
License
Please see the wiki for information regarding The Battle for Wesnoth's licensing:
https://wiki.wesnoth.org/Wesnoth:Copyrights
Installing
See INSTALL.md for instructions on how to build the game from source code.
More Information
For extensive documentation about all aspects of the game, see the official Battle for Wesnoth web site.
A (translated) description of how to play the game can be found in doc/manual/manual.*.html, or online at:
https://wiki.wesnoth.org/WesnothManual
The official Battle for Wesnoth Forums (with over 400,000 posts from more than 20,000 registered members) can be found at: